[Bug 2101] Review request: vbam - High compatibility Gameboy Advance Emulator combining many VBA developments

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2101

--- Comment #23 from Jeremy Newton <alexjnewt at hotmail.com> 2012-01-30 03:01:53 CET ---
(In reply to comment #22)
> I have checked vbam-1.8.0.1054-2.fc16.src.rpm package. There is one missing
> dependency to successfully build the package:
> 
> openal-soft-devel
> 
> Can you please update SPEC file?

Okay I can do that, I must have missed it. Nice catch!

> [-] no files listed twice in %files
>     doc/gpl.txt doc/License.txt
>     I think it's enough to install these files only in common subpackage

Agreed, this does make more sense; I will just include the License files in the
common package.

> [?] package functions as described: Application is running but I have not tried

I have tested running thoroughly, so I can vouch for running on x86-64. i686
should be working perfectly as well.

> [=] package contains man pages for binaries/scripts
>
> ...
>
> Please check the man page issue. Perhaps it would just enough to move man page
> from sdl subpackage to the common package and add vbam-gtk and vbam-wx to the
> names? Please check /usr/share/man/man3/printf.3.gz and man fprintf to see what
> I mean - here one man page describes multiple variants of printf functions.

The manpage for sdl is particular to SDL. The gvbam binary (and I'm pretty sure
the wxvbam as well) just has a -h help option and a -v version option. I don't
believe upstream has any interest in writing man pages for either binary. If it
is required though, I can write one for each myself and include a custom spin
of the source code.

>We are almost at the end of the review process. Good job!

Thanks! Good job on yours as well, I just finished reviewing your package.


Here's the updated SPEC and SRPM with the suggested changes:
SPEC:
http://dl.dropbox.com/u/42480493/vbam.spec
SRPM:
http://dl.dropbox.com/u/42480493/vbam-1.8.0.1054-3.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.