[Bug 2366] Review request: mythweb

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2366

--- Comment #4 from Ken Dreyer <ktdreyer at ktdreyer.com> 2012-07-01 20:54:39 CEST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Must: Please add a %build section. Interestingly your spec crashed
> > fedora-review :) https://bugzilla.redhat.com/836772
> 
> Should we add something just to placate fedora-review? As far as I know it
> isn't strictly needed, unless there's a guideline I missed? It could be added
> manually just to fix fedora-review (which I assume you did) but I'd rather not
> put it in permanently if there's no requirement to do so.

Hmm. I can't find anything on the Fedora wiki about this, but "rpmlint -I
no-%build-section" gives some justification. It's pretty far-fetched, since
mythweb doesn't have debuginfo packages to begin with. I guess I would add it
for rpmlint's sake.


> > Must: Please fix the directory permissions. Something like this should do
> > the trick: find . -type d -print0 | xargs -0 chmod 755 
> 
> Strange, this seems to have been done on purpose by Jarod. I'm not sure why.
> %defattr(-,apache,apache,0775) %{_datadir}/mythweb/
> 
> I took it out. I don't think it should break anything.

Good catch on the defattr. That was probably a typo. We can change it to 755
and skip the find+chmod.


> > I'm not sure mythtv-backend is a strict requirement, since technically the
> > web interface could run on a separate box from the backend server. Same for
> > the Requires: mysql-server.
> 
> Yeah, here I have to choose from the "best compromise" situation since RPM
> fails us here. People who run  separate FE/BE configurations are more likely
> to know what they're doing so and can probably build MythTV from source. I
> suppose though that people who use the everything install via the mythtv meta
> package are covered. I'll think about it.

Yeah, since this is a case where we have a meta package available to us, my
preference would be to let the meta package handle it. Not a big deal though.


> SPEC: https://dl.dropbox.com/u/34775202/mythweb/mythweb.spec
> SRPM: https://dl.dropbox.com/u/34775202/mythweb/mythweb-0.25.1-2.fc16.src.rpm

Looks good, APPROVED

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.