[Bug 2429] Review request: gens-gs - Sega Genesis, Sega CD, and Sega 32X emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429

Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musuruan at gmail.com

--- Comment #1 from Andrea Musuruane <musuruan at gmail.com> 2012-07-31 12:19:45 CEST ---
Hi Jeremy! I had a glance yesterday at your package and I found some issues.
But I noticed that the version you are packaging is almost 3 years old. 

Considering the current upstream GIT version uses another build-system and
another toolkit, I wonder if it is not the case to package a preview of the
next release, thus you can work with upstream to solve some issues. What do you
think?

BTW, the License: field refers to the licenses of the contents of the binary
rpm. It is not a list of licences used in the source files. Therefore the
license of gens-gs should be GPLv2+ (that is what you get combining LGPLv2+ and
GPLv2+ sources).
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field

Both v2.16.7 and the current GIT version are bundling a lot of external
libraries. This is not permitted and the package should be patched to use the
system libraries.
https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

Conflicts should also be avoided. You can work with upstream to resolve the
conflict with gens. I don't know how stable is the current GIT version, so
there can be a time where a user wants to have both gens and gens-gs installed. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Conflicts

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.