[Bug 2140] bombono-dvd - DVD authoring program with nice and clean GUI

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2140

--- Comment #40 from Alec Leamas <leamas.alec at gmail.com> 2012-03-31 08:02:14 CEST ---
(In reply to comment #38)

> Alright! Lets get this review going:

Alright! I reply now to what I think might need a discussion, back later with
new links (short of time). I have excluded remarks which don't need discussion.

> [-] package meets the packaging guidelines
> =The group category should be removed, as it is no longer required.

My understanding is that although Fedora ignores it, it's still wise to include
it:
http://fedoraproject.org/wiki/Packaging_tricks#Recommended_values_for_the_Group:_tag

>> -%{?rel_tag} is not necessary, please remove it
>%{?rel_tag} should not be in the version, please remove it and move it to
release
Sometimes, I try new territorites: my understanding is that including the
release tag is possible and even desirable since it's¸more robust. My
reasoning, based on the same link:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages
+This is a post-release
+Version tags are either properly ordered or not.
+The git tags like 20120329git1234567 are properly ordered thanks to the date
prefix
+In this case the link explicitly says that the git tag might go into the
version (but without examples).
+Or?!


> [-] package builds on at least one primary arch:
> I get these errors:
> src/mlib/sdk/asl_any_iter.h:6:34: fatal error: adobe/any_iterator.hpp: No such
> file or directory
Hm...
$ rpm -qf /usr/include/adobe/any_iterator.hpp
adobe-source-libraries-devel-1.0.43-8.fc16.i686

Is there a dependency missing? Have you adobe-source-libraries-devel installed?
Are  you building in mock?

-Requires(post) and (postun) is not necessary, please remove it
To my understanding, they are needed:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.