[Bug 2325] vdr-mp3 - Sound playback plugin for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2325

Nicolas Chauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |4
         AssignedTo|rpmfusion-package-review at rp |kwizart at gmail.com
                   |mfusion.org                 |

--- Comment #5 from Nicolas Chauvet <kwizart at gmail.com> 2012-05-18 16:00:52 CEST ---
Starting patch review.

OK - This package can be in RPM Fusion since it rely on libmad build time and
mplayer at runtime.
OK - Patch is legible an only contain atomic changes. Good.
OK - Package owns every directory it relies on.

Rpmlint outputs:
OK - Note on dangerous commande in %post. Related to a package transition, OK.


Just one note about the release tag. We usually reset the release tag to 1 on
package update, there is not stric guideline that mandate/forbid this IIRC. But
it helps knowning the freshness of a given version.

Also you should try to get the patches upstreamed and provided a link to the
upstream bugreport if it's not yet in a released tarball. I will not mandate
that for this review.


---------

This package (vcd-mp3) is APPROVED by me

---------



Please create a RPM Fusion FAS account, and continue with the import process.

Thx

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.