[Bug 2527] Review request:librcd - Russian Encoding Detection Library

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2527

Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musuruan at gmail.com

--- Comment #1 from Andrea Musuruane <musuruan at gmail.com> 2012-10-13 19:06:32 CEST ---
Can you please state why this package is not eligible for Fedora?

If NEWS file is empty there is no need to include it.

Do not use %makeinstall macro:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

Buildroot, clean section and defattr are no longer required:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions

These lines are not required or necessary:
Prefix: %{_prefix}
Docdir: %{_docdir}

Changelog should reflect RPM changes but now it's empty.

Release number must start from 1:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.