[Bug 2527] Review request:librcd - Russian Encoding Detection Library

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2527

--- Comment #3 from Antonio <anto.trande at gmail.com> 2012-10-13 19:48:15 CEST ---
(In reply to comment #1)
> If NEWS file is empty there is no need to include it.
> 
> Do not use %makeinstall macro:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
> 
> Buildroot, clean section and defattr are no longer required:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
> 
> These lines are not required or necessary:
> Prefix: %{_prefix}
> Docdir: %{_docdir}
> 
> Changelog should reflect RPM changes but now it's empty.
> 
> Release number must start from 1:
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

http://sagitter.fedorapeople.org/librcd.spec
http://sagitter.fedorapeople.org/librcd-0.1.13-1.fc17.src.rpm

$ rpmlint librcd-0.1.13-1.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint librcd-0.1.13-1.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.