[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #30 from Giles Birchley <gbirchley at blueyonder.co.uk> 2012-10-15 23:06:55 CEST ---
Sorry to have left this hanging around so long. Things got very busy, just
trying to carve out some time to finish this off.

Updated rpm and spec:


SPEC file:
http://forums.pcsx2.net/attachment.php?aid=40503
SRC RPM:
http://forums.pcsx2.net/attachment.php?aid=40502

Changes:

Switched to package posted by upstream

I have patched out -m32 from CFLAGS. I was unsure after the exchange if -i686
should be in or out after the flurry of conflicting comments. Gregory seemed to
imply pcsx2 would not build properly without, so I left it in for now anyway.

rpmlint report of fsf errors has been sent to upstream

Build options have been changed to Gregory's suggestions

I have a few rpmlint errors on the rpm but almost none worth speaking of on the
src rpm

As this is a new package I have altered the changelog - no need to include all
the stuff from the svn revision builds

rpm:
$ rpmlint pcsx2-1.0.0-1.fc16.i686.rpm
pcsx2.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/pcsx2-1.0.0/GPL.txt
pcsx2.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/pcsx2-1.0.0/License.txt
pcsx2.i686: E: script-without-shebang
/usr/share/icons/hicolor/128x128/apps/pcsx2.xpm
pcsx2.i686: W: no-manual-page-for-binary pcsx2_ZZCGReplayLoader
pcsx2.i686: W: no-manual-page-for-binary pcsx2_ZZReplayLoader
pcsx2.i686: W: no-manual-page-for-binary pcsx2_GSReplayLoader
pcsx2.i686: E: non-empty-%post /sbin/ldconfig
pcsx2.i686: E: non-empty-%postun /sbin/ldconfig
1 packages and 0 specfiles checked; 3 errors, 5 warnings.

I presume first ones are complaining about .txt file
script without shebang does not seem to be corrected by removing executable bit
from file. Not sure if it's important
no man page- not important I think
non-empty-xxxx -- I copied the script from fedora packagers instructions so I
think this is okay?

srcrpm:
$ rpmlint pcsx2-1.0.0-1.fc16.src.rpm
pcsx2.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
pcsx2.src: W: invalid-url Source0: pcsx2-linux_source-1.0.0-rev5412.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

First one I can correct if this is important, but left it for now
I think the invalid-url is not important, as Gregory has uploaded file to pcsx2
noticeboard it has an aid number rather than package name, but downloads okay
with wget 

Hopefully this is getting there, but do let me know your comments.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.