[Bug 2532] Review request: Gmediafinder - software to search stream an/or download files
RPM Fusion Bugzilla
noreply at rpmfusion.org
Sun Oct 28 13:41:17 CET 2012
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2532
--- Comment #9 from Michel Alexandre Salim <michel+rpmf at sylvestre.me> 2012-10-28 13:41:17 CET ---
Apologies for the delay; had it built in Mock a few days ago but wanted to do
some functionality test and write the review properly.
Several items still need fixing, see below:
Package Review
==============
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
[!]: Package is named according to the Package Naming Guidelines.
Since upstream never released tarballs, please mark the Git
revision you're packaging. see
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages
Also, the directory win32 is bloating the download size, it
appears upstream packaged ffmpeg for Windows *twice* (one
archived and one unpacked). Remove them.
Update the checkout instruction accordingly; e.g.
# git rev-parse --short HEAD (or whichever revision you want to package)
%global gitrev ...
# checkout instructions
# git archive --format=tar --prefix=gmediafinder/ %{gitrev} \
# -o gmediafinder-%{version}-%{gitrev}.tar
# tar --delete --file=gmediafinder-%{version}-%{gitrev}.tar \
# gmediafinder/win32
# bzip2 gmediafinder-%{version}-%{gitrev}.tar
Using tar directly is not advisable as the directory ordering is
not guaranteed, so it will be hard to reproduce the tarball on a
different machine. Ditto with not specifying the git revision
[!]: Package contains BR: python2-devel or python3-devel
You're already relying on python-setuptools, so this can be ignored
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[!]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
You are shipping such a file, but even though it's installed for
you, you still need to call desktop-file-validate on it to make
sure it's valid
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
[!]: Package requires other packages for directories it uses.
Need to require hicolor-icon-theme at runtime as well because of
files put into %{_datadir}/icons/hicolor
[!]: Package must own all directories that it creates.
Need to own:
%{_datadir}/%{name}
%{_datadir}/pyshared
%{_datadir}/pyshared/GmediaFinder
- For the first and last items, you want to own the directories
and not just the files under them
- For the second item, it's because no other package (that you
depend on) currently owns %{_datadir}/pyshared, so you want to
avoid that directory dangling behind when gmediafinder is
removed
[!]: Latest version is packaged.
Latest version is 1.0.4 since git hash e7f8757
[!]: Spec file is legible and written in American English.
Please tidy up the description - while it comes from the author's
gnome-files listing, it's full of misspellings
[!]: SourceX is a working URL.
w.r.t. the source:
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[!]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[!]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/michel/sources/fedora/reviews/review-
gmediafinder/licensecheck.txt
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[!]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
Python:
[!]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[!]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: SourceX / PatchY prefixed with %{name}.
[!]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
But there are no bundled tests anyway
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gmediafinder-1.0.3-2.fc18.noarch.rpm
gmediafinder-1.0.3-2.fc18.src.rpm
gmediafinder.noarch: W: spelling-error %description -l en_US gstreamer ->
streamer, g streamer, steamer
gmediafinder.noarch: W: spelling-error %description -l en_US flv -> fl, flt,
flu
gmediafinder.noarch: W: no-manual-page-for-binary gmediafinder
gmediafinder.src: W: spelling-error %description -l en_US gstreamer ->
streamer, g streamer, steamer
gmediafinder.src: W: spelling-error %description -l en_US flv -> fl, flt, flu
gmediafinder.src: W: invalid-url Source0: gmediafinder-1.0.3.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint gmediafinder
gmediafinder.noarch: W: spelling-error %description -l en_US gstreamer ->
streamer, g streamer, steamer
gmediafinder.noarch: W: spelling-error %description -l en_US flv -> fl, flt,
flu
gmediafinder.noarch: W: no-manual-page-for-binary gmediafinder
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'
Requires
--------
gmediafinder-1.0.3-2.fc18.noarch.rpm (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
/usr/bin/python
gnome-icon-theme
gstreamer-ffmpeg
gstreamer-plugins-bad
gstreamer-plugins-base
gstreamer-plugins-good
gstreamer-python
projectM-libvisual
pygtk2
pygtk2-libglade
python(abi) = 2.7
python-BeautifulSoup
python-configobj
python-distutils-extra
python-gdata
python-mechanize
python-virtkey
pywebkitgtk
Provides
--------
gmediafinder-1.0.3-2.fc18.noarch.rpm:
gmediafinder = 1.0.3-2.fc18
MD5-sum check
-------------
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -m fedora-18-x86_64-rpmfusion_free -n
gmediafinder
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the rpmfusion-developers
mailing list