[Bug 2378] Review Request: edgar - A platform game

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2378

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |4

--- Comment #7 from Hans de Goede <j.w.r.degoede at gmail.com> 2012-10-28 14:19:43 CET ---
Hi,

Sorry for being a bit slow.

Full review done:

Good:
- rpmlint checks return:
[hans at localhost ~]$ rpmlint rpmbuild/RPMS/x86_64/edgar-*
rpmbuild/SRPMS/edgar-1.04-1.fc18.src.rpm 
edgar.x86_64: W: no-manual-page-for-binary edgar
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
 -this can be ignored IMHO
- package meets naming guidelines
- package meets packaging guidelines
- license text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales properly handled
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code + necessary content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file properly installed

-Needs work:
 - license (GPLv2+) should be "GPLv2+ and freely redistributable, no commercial
use", which is the whole reason why this is going to rpmfusion in the first
place. Note that this also means that this needs to go to non-free (for now),
and once we can have it cleaned up it can go to Fedora, rather then to free

I trust you'll fix the license tag before building, so this packaged is
*approved*.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.