[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #6 from Andrea Musuruane <musuruan at gmail.com> 2012-09-03 10:46:21 CEST ---
(In reply to comment #5)
Hi Giles,

> I'm having a go at responding to your ideas, but I'm having problems with the
> build when I remove the specified cflags. I have patched BuildParameters.cmake
> to remove the offending flags;
[..[
> but the SSE flag seems to be not passed to cmake:

They are not passed to cmake because you correctly patched out the flags
("-msse -msse2"). But it seems the software demands SSE and SSE2. This is a big
problem because not all i686 architectures supported by Fedora supports SSE or
SSE2. I don't know if this is allowed. I think not, but I suggest you to ask
for advice on the rpmfusion-devel mailing list. 

> Another comment - you ask that I specify the build type as Debug and report the
> errors from rpmlint - I assume this is not for the final build? Debug build of
> pcsx2 runs very slowly compared to Release.

AFAIK Debug just produce debug symbols and these are needed to have a correct
debuginfo RPM package. This is needed for the final build too.

> Full pcsx2 licensing information is at the following url:
> http://code.google.com/p/pcsx2/source/browse/branches/1.0/debian-unstable-upstream/copyright
> You are right that LGPLv3+ is the correct license, sorry ...

After carefully looking at these licenses, the resulting license is: GPLv3. 

Ignoring file in debian/* because they are not used (LGPLv3).

Expat, BSD-3-Clause, SGI FREE SOFTWARE LICENSE B 2.0 and PD are all compatible
with both GPL and LGPL.
https://www.gnu.org/licenses/license-list.html

Mixing LGPLv3+ and LGPLv2+ you get LGPLv3+.

Mixing GPLv2+ and LGPLv3+ you get ***GPLv3***.
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

Upstream should be notified. If they really want to release pcsx2 under LGPLv3+
they must re-license files under GPLv2+ to LGPLv2+ or LGPLv3+.

> I am downloading from svn specifying a revision because the format of the
> create_pcsx2_tarball.sh script needs a revision as well a branch. As the branch
> is 1.0, the revision is immaterial. I can change the script so it doesn't
> specify a revision if this is more acceptable. The script also does not
> download the 3rd party libraries AFAIK.

I still don't get why you are not using upstream tarball (available here:
http://pcsx2.net/download/releases/linux/viewcategory/4-linux.html) instead of
a svn checkout. 

> Although it is a WIP I have uploaded the new spec to:
> http://forums.pcsx2.net/attachment.php?aid=40016

These are not needed:
# The following files are under GNU General Public License v3.0 only: pcsx2/*,
common/*, plugins/spu2-x/*, plugins/PadNull/Pad*, plugins/USBnull/*,
plugins/FWnull/*, plugins/CDVDnull/CDVD*, plugins/GSnull/*,
plugins/dev9null/DEV9.cpp
# The following files are under GNU General Public License v2.0 or later:
pcsx2/Mdec.cpp, pcsx2/Mdec.h, pcsx2/RDebug/deci2_drfp.cpp,
pcsx2/IPU/mpeg2lib/*, pcsx2/cheatscpp.h, common/include/api/*,
plugins/onepad/*, plugins/PadNull/Linux/*, plugins/SPU2null/*,
plugins/FWnull/FW.cpp, plugins/zerospu2/*, plugins/zzogl-pg/*,
plugins/GSnull/Registers.h, plugins/GSnull/Linux/Linux*,
plugins/GSnull/Linux/Config*, plugins/dev9null/DEV9.h,
plugins/dev9null/Config.*
# The following files are under GNU Lesser General Public License v2 (or 2.1)
or later: plugins/spu2-x/src/Spu2replay.*, plugins/spu2-x/src/Decode*,
plugins/spu2-x/src/Linux/ConfigSoundTouch.cpp, plugins/spu2-x/src/spdif.h,
plugins/spu2-x/src/Debug.h
# The following files are under MIT license (also X11) Copyright 1991-2000,
Silicon Graphics, Inc: plugins/zzogl-pg/opengl/glprocs.*
# The following file is under MIT license (also X11) Copyright 2006,
KJK:Hyperion <hackbunny at reactos.com>: common/include/intrin_x86.h
# The following file is under BSD license (no advertising) Copyright 2002,
Michael Ringgaard: common/src/Utilities/vssprintf.cpp
# The following file is licensed under Public Domain:
plugins/zzogl-pg/opengl/zpipe.cpp 
# The license status of the following files is unknown:
plugins/zzogl-pg/opengl/ZeroGSShaders/zerogsshaders*

All patch names should begin with the package name and (not mandatory but
strongly suggested) by version name. I.e. pcsx2-1.0-fedora_cmake.patch

Some lines are too long to be read. Split them on multiple lines with "\".

As already reported /usr/share/pixmaps is not a "wrong" place for Fedora. It is
acceptable.

Other remarks I gave you still applies but I think you haven't yet finished
updating the package.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.