[Bug 2921] Review request: openmw - Unofficial open source engine re-implementation of the game Morrowind

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2921

Antonio <anto.trande at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande at gmail.com

--- Comment #1 from Antonio <anto.trande at gmail.com> 2013-08-15 12:23:55 CEST ---
Hi Alexandre.

I'm not a sponsor so I can just do some comments about your package.

Above all, there are various basic errors among first lines in your spec file:

- Source?: "The most common case is where upstream distributes source as a
tar.gz, tar.bz2 or zip archive that we can download from an upstream website.
In these cases you must use a full URL to the package in the SourceX: line."
See http://fedoraproject.org/wiki/Packaging:SourceURL

- Patch0:  "All patches should have an upstream bug link or comment" 
http://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_of_multiple_projects

- BuildRequires/Requires can be listed in multilines in order to make .spec
file more legible.

- Description and Summary sections are identical. Description must explain
better what this software does.
"About" paragraph in its homepage (https://code.google.com/p/openmw/) is more
appropriate.

And now we analyze the compilation further.
In %build, %install, %files sections, you don't use any RPM macro. Packaging
Guidelines (http://fedoraproject.org/wiki/Packaging:Guidelines#Macros) says:

"Packagers are strongly encouraged to use macros instead of hard-coded
directory names, see http://fedoraproject.org/wiki/Packaging:RPMMacros". So
your %build section becomes:

%build
%cmake -D CMAKE_INSTALL_PREFIX:PATH=%{_prefix} \ -D
DATADIR:PATH=%{_datadir}/games/%{name} \ -D DOCDIR:PATH=%{_docdir}/%{name} \ -D
MANDIR:PATH=%{_mandir} \ -D BINDIR=%{_bindir} \ -D DATAROOTDIR:PATH=%{_datadir}
\ -D ICONDIR=%{_datadir}/pixmaps . 
make %{?_smp_mflags}

This is just an example, also because, probably,you don't even need to set all
cmake options, since %cmake macro already sets up the same options
automatically. 
See '$ rpm --eval %cmake' command output.

All macros are missing in %files section, too.
In fine, %doc line is empty! See
http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

There are other points which need to be fixed, later. :)

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.