[Bug 2921] Review request: openmw - Unofficial open source engine re-implementation of the game Morrowind

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2921

--- Comment #3 from Antonio <anto.trande at gmail.com> 2013-08-17 16:19:00 CEST ---
(In reply to comment #2)
> I fix all your bug, see the new srpm:
> http://download.tuxfamily.org/crearemundum/openmw-0.25.0-1.fc19.src.rpm
> 

Not just the srpm but also a link to the spec file.

- 'mygui-devel' package is missing and the compilation fails!
Test your package before to propose it for a review.

- All those backslash have a specific role, they are needed to "cut" entire
command in multilines. (See this example:
http://pkgs.fedoraproject.org/cgit/metis.git/tree/metis.spec)
You can (and must) also fix all installation directories following the Games
Packaging guidelines (https://fedoraproject.org/wiki/SIGs/Games/Packaging) so
all data files are installed in %{_datadir}/%{name}, not
%{_datadir}/games/%{name}; and man pages (if exist) for games go in section 6:
%{_mandir}/man6

- All .desktop files must be validated (see
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files)

- 'rm -rf $RPM_BUILD_ROOT' clean command is not required for F-13 and above,
and for EPEL6.

- %doc line is still empty ! 

. All %changelog entries must list all changes done on your spec file. (See
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs)

"Fix bug (see https://bugzilla.rpmfusion.org/show_bug.cgi?id=2921)."

is NOT sufficient.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.