[Bug 3035] Review request: dhewm3 - Dhewm's Doom 3 engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3035

--- Comment #4 from Simone Caronni <negativo17 at gmail.com> 2013-12-02 12:57:08 CET ---
(In reply to comment #2)
> - Compilation uses the 'dhewm3/neo/idlib/Base64.cpp' file; it's released with a
> BSD license.
> Please, update License tag.

Done.

> - Use %global instead of %define.

Fone.

> - Fix 'file-not-utf8' warning of the file '/usr/share/doc/dhewm3/COPYING.txt'

Done.

> - Fix 'strange-permission' warning of the file 'dhewm3-git-checkout.sh'
> 
> - 'invalid-url' warning in 'Source0' can be fixed by indicating a direct link
> to the zipped source archive file
>  
> To me, it looks that  [1] is applicable here?!
> 
> [1] http://fedoraproject.org/wiki/Packaging:SourceURL#Github

Done, I've applied the GitHub sourceURL as specified in the packaging
guidelines. The script file was a leftover when I was unbundling zlib, jpeg,
etc.

> - There are bundled files in the neo/framework/minizip/ directory. They are
> already packaged in the 'minizip' package.
> Please, remove them in the %setup section and add the 'minizip-devel' BR.
> Perform the rpm buildings newly in koji, even for EPEL and post the links.

Unfortunately this is not so easy. The bundled Minizip has been customized with
one extra function:

https://github.com/dhewm/dhewm3/blob/master/neo/framework/minizip/unzip.cpp#L68
https://github.com/dhewm/dhewm3/blob/master/neo/framework/minizip/unzip.cpp#L2159

In fact it's the only libraries that has been left bundled when the original Id
source was cleaned up. I'm looking if I can remove it with a patch; If anyone
wants to give some help I would greatly appreciate it.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.