[Bug 3043] Review request: lfp-flash-plugin - Adobe Flash Player package bootstrap
RPM Fusion Bugzilla
noreply at rpmfusion.org
Sat Dec 7 07:14:06 CET 2013
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3043
--- Comment #17 from Alec Leamas <leamas.alec at gmail.com> 2013-12-07 07:14:06 CET ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
======
- Useful -debuginfo package or justification otherwise (please
justify the debug_package and _strip).
- Fix the mixed tabs in the spec (rpmlint warning)
- Please add an empty build section, makes things easier for other
programs parsing the spec.
===== MUST items =====
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: License is acceptable in a lpf context.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in flash-plugin-properties
[!]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines, besides rpmfusion
modifications.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Fully versioned dependency in subpackages if applicable.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: flash-plugin-11.2.202.327-2.fc21.i686.rpm
flash-plugin-properties-11.2.202.327-2.fc21.i686.rpm
flash-plugin-11.2.202.327-2.fc21.src.rpm
flash-plugin.i686: W: invalid-license Non-redistributable, no modification
permitted
flash-plugin-properties.i686: W: spelling-error %description -l en_US
perferences -> preferences, references, conferences
flash-plugin-properties.i686: W: invalid-license Non-redistributable, no
modification permitted
flash-plugin-properties.i686: W: no-documentation
flash-plugin-properties.i686: W: no-manual-page-for-binary
flash-player-properties
flash-plugin.src: W: invalid-license Non-redistributable, no modification
permitted
flash-plugin.src: W: no-%build-section
flash-plugin.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
2)
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint flash-plugin flash-plugin-properties
flash-plugin.i686: W: invalid-license Non-redistributable, no modification
permitted
flash-plugin-properties.i686: W: spelling-error %description -l en_US
perferences -> preferences, references, conferences
flash-plugin-properties.i686: W: invalid-license Non-redistributable, no
modification permitted
flash-plugin-properties.i686: W: no-documentation
flash-plugin-properties.i686: W: no-manual-page-for-binary
flash-player-properties
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
# echo 'rpmlint-done:'
Requires
--------
flash-plugin (rpmlib, GLIBC filtered):
ld-linux.so.2
libX11.so.6
libXcursor.so.1
libXext.so.6
libXrender.so.1
libXt.so.6
libatk-1.0.so.0
libc.so.6
libcairo.so.2
libdl.so.2
libfontconfig.so.1
libfreetype.so.6
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgobject-2.0.so.0
libgthread-2.0.so.0
libgtk-x11-2.0.so.0
libm.so.6
libnspr4.so
libnss3.so
libnss3.so(NSS_3.10)
libnss3.so(NSS_3.11)
libnss3.so(NSS_3.12)
libnss3.so(NSS_3.2)
libnss3.so(NSS_3.3)
libnss3.so(NSS_3.4)
libnss3.so(NSS_3.6)
libnss3.so(NSS_3.9)
libnss3.so(NSS_3.9.2)
libnssutil3.so
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libplc4.so
libplds4.so
libpthread.so.0
librt.so.1
libsmime3.so
libsmime3.so(NSS_3.2)
libsmime3.so(NSS_3.4)
libssl3.so
libssl3.so(NSS_3.2)
mozilla-filesystem
flash-plugin-properties (rpmlib, GLIBC filtered):
/bin/sh
flash-plugin(x86-32)
hicolor-icon-theme
ld-linux.so.2
libatk-1.0.so.0
libc.so.6
libcairo.so.2
libdl.so.2
libfontconfig.so.1
libfreetype.so.6
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgobject-2.0.so.0
libgtk-x11-2.0.so.0
libm.so.6
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
Provides
--------
flash-plugin:
flash-plugin
flash-plugin(x86-32)
lib_plugin.so
flash-plugin-properties:
application()
application(flash-player-properties.desktop)
flash-plugin-kde
flash-plugin-properties
flash-plugin-properties(x86-32)
Unversioned so-files
--------------------
flash-plugin: /usr/lib/mozilla/plugins/libflashplayer.so
Source checksums
----------------
http://fpdownload.macromedia.com/get/flashplayer/pdc/11.2.202.327/install_flash_player_11_linux.i386.tar.gz
:
CHECKSUM(SHA256) this package :
1fbbadf17c86b3fd52bbf1df299f52c0b2eb7a0b9aca1d55756bc884c9270f62
CHECKSUM(SHA256) upstream package :
1fbbadf17c86b3fd52bbf1df299f52c0b2eb7a0b9aca1d55756bc884c9270f62
http://fpdownload.macromedia.com/get/flashplayer/pdc/11.2.202.327/install_flash_player_11_linux.x86_64.tar.gz
:
CHECKSUM(SHA256) this package :
34248b36f4b640c0b3846a334f995414c1bf4c8813ec80e2dbd3028d38bb4235
CHECKSUM(SHA256) upstream package :
34248b36f4b640c0b3846a334f995414c1bf4c8813ec80e2dbd3028d38bb4235
Generated by fedora-review 0.5.0 (6defee6) last change: 2013-10-04
Command line :./try-fedora-review -rn
/home/mk/FedoraReview/flash-plugin-11.2.202.327-2.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the rpmfusion-developers
mailing list