[Bug 2492] Review request: mame-data-extras - Extra data files for MAME

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492

--- Comment #14 from Julian Sikorski <belegdol at gmail.com> 2013-02-05 20:29:52 CET ---
Sorry it took so long, I was waiting for all the files getting updated to
0.148. They didn't.

Spec URL: http://lesloueizeh.com/belegdol/mame-data-extras.spec
SRPM URL: http://lesloueizeh.com/belegdol/mame-data-extras-0.148-1.fc19.src.rpm

(In reply to comment #13)
> Hi, sorry for this big delay, I have been very very busy.
> If you have something that don't understand on this comment, please tell me.
> This is based on fedora-review, I think some items could be improved, after
> that I will approved the review.
> Thanks.
> 
> 
> [!] = Fail
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. No licenses
>      found. Please check the source files for licenses manually.
> See: http://fedoraproject.org/wiki/Packaging
> /LicensingGuidelines#ValidLicenseShortNames

I am actually not sure what license the files are. I could try emailing the
respective authors asking for permission, but this is bound to take a while.

> 
> [!]: Large documentation must go in a -doc subpackage.
>      Note: Documentation size is 14807040 bytes in 13 files.
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
> 

I killed some unnecessary files, should be better now

> 
> ===== MUST items =====
> 
> [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
>      Note: rm -rf %{buildroot} present but not required
> 

Are you sure this is wrong? Can't find a mention of it in the guidelines.

> 
> ===== SHOULD items =====
> 
> [!]: Spec use %global instead of %define.
>      Note: %define vernumber 147

Done.

> 
> Rpmlint
> -------
> mame-data-extras.src: W: file-size-mismatch messinfo.zip = 1902507,
> http://www.progettosnaps.net/messinfo/messinfo.zip = 1940181
> mame-data-extras.src: W: file-size-mismatch cheat0147.zip = 759300,
> http://cheat.retrogames.com/download/cheat0147.zip = 760065
> 
> http://cheat.retrogames.com/download/cheat0147.zip :
>   CHECKSUM(SHA256) this package     :
> cc5a46a1814a4124f68880500e7736246991d8eca35f3ca46cec4d4a9739c166
>   CHECKSUM(SHA256) upstream package :
> 4bd1524583070180798014a14a97478b6c90e633ae90db530862bcacfb5d257e
> 
> http://www.progettosnaps.net/messinfo/messinfo.zip :
>   CHECKSUM(SHA256) this package     :
> d0c166fe7acd8294a7caa9703b953dc98551da5a8401f86bdf391d33dbf6507b
>   CHECKSUM(SHA256) upstream package :
> 6712cd2340c6484ac8518d8c9a46b851b755691f67c3140bd06dedc309dff83b
> 
> mame-data-extras-robby.noarch: W: spurious-executable-perm
> /usr/share/mame/roms/robby.zip

Fixed.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.