[Bug 2717] Review Request: pianobar - Command-line Pandora Internet radio client

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2717

--- Comment #3 from Alec Leamas <leamas.alec at gmail.com> 2013-03-12 16:51:34 CET ---
(In reply to comment #2)
> pianobar builds and runs on Fedora without libfaad2 and without libmad.
> However, when I ran it in that configuration, everything worked except for
> playback. I could view and manage my stations, but as soon as I attempted to
> play one, I was informed that support for AAC was not compiled into the
> application. So it can go into core Fedora but would probably generate nothing
> but a long string of complaints from users.
Fair enough for me.

> I'm a Fedora packager. FAS account greghellings.
Good!


> Changing the build target to 'make debug' added the debug symbols to the build
> and cleaned up that warning. New SRPM is
> 
> http://dl.thehellings.com/pianobar/pianobar-2012.12.01-3.fc18.src.rpm
Following that link you would also find that you have not applied %optflags. I
suggest that you do that first (needed anyway) and sees if that's enough to
build the -debuginfo package.

Please always publish both spec: and srpm: links when updating.

Some other remarks:
- At a glance only find BSD license in the code.  Why is License: LGPL or ASL?
- What's the purpose of he _pkg_name macro? Why not just refer to %{name}?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.