[Bug 1990] Review request: spl - Solaris Porting Layer

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1990

Brian Behlendorf <behlendorf1 at llnl.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |behlendorf1 at llnl.gov

--- Comment #6 from Brian Behlendorf <behlendorf1 at llnl.gov> 2013-03-14 00:03:07 CET ---
I'd like to revive this packaging request.  The following are refreshed
packages using the latest source from http://zfsonlinux.org.

User space utilities:
SPEC: https://www.dropbox.com/s/0f4gbu1yeni2e7w/spl.spec
SRPM: https://www.dropbox.com/s/pwc30xvltr3awpj/spl-0.6.0-rc14.fc18.src.rpm

Kernel modules:
SPEC: https://www.dropbox.com/s/8sivj1ui6jozbrz/spl-kmod.spec
SRPM:
https://www.dropbox.com/s/h1fmvqe2as8w552/spl-kmod-0.6.0-rc14.fc18.src.rpm

These packages depend on the kmodtool patch in bug #2714.  The patch adds
generic support for kmod-<package>-devel packages which allows us to build the
zfs kmod packages cleanly using the kmod-spl-devel packages.  Since those
changes are still under review the SRPM contains a patched version of the
kmodtool script which is used.  The kmodtool script was also extended to take a
--prefix argument so it can be used for fc[16-18].

The output from rpmlint is still a little more chatty than I'd like.  However,
many of the errors are related to the package version.  I've chosen to ignore
them for now because they will be cleanly addressed when the official 0.6.1
release is tagged.  That should be within a few weeks, but before that happens
I wanted to get an initial review started to address any concerns.


$ rpmlint spl*
spl.src: W: invalid-url Source0: spl-0.6.0.tar.gz
spl-kmod.src: W: invalid-url Source0: spl-0.6.0.tar.gz
spl.x86_64: W: incoherent-version-in-changelog 0.6.0-1 ['0.6.0-rc14.fc18', ...]

* Ignore these for now until a proper spl-0.6.1 release is tagged by upstream.

spl.x86_64: W: no-manual-page-for-binary splat

* Not yet provided by upstream.

spl-kmod.src: W: strange-permission kmodtool 0775L

* Expected to be executable, this script can be retired if the suggested
kmodtool extensions described above are merged.

5 packages and 0 specfiles checked; 0 errors, 5 warnings.


$ rpmlint kmod-spl-*
kmod-spl.x86_64: W: spelling-error Summary(en_US) Metapackage -> Meta package,
Meta-package, Prepackage
kmod-spl.x86_64: W: no-documentation
kmod-spl-3.8.2-206.fc18.x86_64.x86_64: W: summary-not-capitalized C spl kernel
module(s) for 3.8.2-206.fc18.x86_64
kmod-spl-3.8.2-206.fc18.x86_64.x86_64: W: no-documentation

* My understanding is that this is expected noise for kmod2 packages.

kmod-spl-3.8.2-206.fc18.x86_64.x86_64: W: unstripped-binary-or-object
/usr/lib/modules/3.8.2-206.fc18.x86_64/extra/spl/spl/spl.ko
kmod-spl-3.8.2-206.fc18.x86_64.x86_64: W: unstripped-binary-or-object
/usr/lib/modules/3.8.2-206.fc18.x86_64/extra/spl/splat/splat.ko

* The objects have the correct permissions, I'm not entirely sure why they
didn't get stripped.

kmod-spl-devel.x86_64: W: summary-not-capitalized C spl kernel module(s) devel
common
kmod-spl-devel.x86_64: W: no-documentation
kmod-spl-devel-3.8.2-206.fc18.x86_64.x86_64: W: summary-not-capitalized C spl
kernel module(s) devel for 3.8.2-206.fc18.x86_64
kmod-spl-devel-3.8.2-206.fc18.x86_64.x86_64: W: no-documentation
kmod-spl-devel-3.8.2-206.fc18.x86_64.x86_64: W: devel-file-in-non-devel-package
/usr/src/spl-0.6.0/3.8.2-206.fc18.x86_64/spl_config.h

* The new kmod development packages.  The common kmod-spl-devel package
contains any required headers, and the mod-spl-devel-<kernel> package contains
per-kernel build objects such as Modules.symvers file.

4 packages and 0 specfiles checked; 0 errors, 11 warnings.

The full package list produced by these two source rpms for the latest 3.8.2
kernel is as follows:

spl-0.6.0-rc14.fc18.src.rpm
spl-kmod-0.6.0-rc14.fc18.src.rpm

spl-0.6.0-rc14.fc18.x86_64.rpm
spl-debuginfo-0.6.0-rc14.fc18.x86_64.rpm
spl-kmod-0.6.0-rc14.fc18.src.rpm
spl-kmod-debuginfo-0.6.0-rc14.fc18.x86_64.rpm
kmod-spl-0.6.0-rc14.fc18.x86_64.rpm
kmod-spl-3.8.2-206.fc18.x86_64-0.6.0-rc14.fc18.x86_64.rpm
kmod-spl-devel-0.6.0-rc14.fc18.x86_64.rpm
kmod-spl-devel-3.8.2-206.fc18.x86_64-0.6.0-rc14.fc18.x86_64.rpm

This is also my first RPM fusion package and I'm looking for a sponsor.  Thanks
in advance!

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.