[Bug 2762] Review request: warsow - Fast paced 3D first person shooter

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|2                           |3
         AssignedTo|rpmfusion-package-review at rp |j.w.r.degoede at gmail.com
                   |mfusion.org                 |

--- Comment #5 from Hans de Goede <j.w.r.degoede at gmail.com> 2013-05-05 21:12:22 CEST ---
Full review done:

Good:
- rpmlint checks return:
 warsow.src:1: E: hardcoded-library-path in %{_prefix}/lib/warsow
 Thisc an be ignored because of the special nature of the libs
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file properly installed

Needs work:
- rpmlint checks return:
 warsow.x86_64: W: file-not-utf8 /usr/share/doc/warsow-1.02/license.txt
 - See: http://pkgs.fedoraproject.org/cgit/usbview.git/tree/usbview.spec for an
example howto fix this
 warsow.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/warsow-1.02/OLD_player_models_guide.doc
 warsow.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/warsow-1.02/sourcecode_quickstart.txt
 warsow.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/warsow-1.02/license.txt
  -It seems most of the files under docs are not really useful for end-users,
so I would only include license.txt in %doc
 -This warning can be fixed for license.txt like this:
  sed -i.bak 's/\r//' docs/license.txt
  touch -r docs/license.txt.bak docs/license.txr
-COPYING (gpl text) not in %doc, please ask upstream to include it in future
releases of the "sdk"
-Does not own all dirs it creates, must add a "Requires: hicolor-icon-theme"
for proper owner ship  of the icon dirs

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.