[Bug 2782] Review request: abuse - The classic Crack-Dot-Com game

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782

Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |4

--- Comment #7 from Kalev Lember <kalevlember at gmail.com> 2013-05-16 15:51:31 CEST ---
RPMFusion review abuse-0.8-3.fc20.src.rpm 2013-05-16

$ rpmlint abuse \
          abuse-debuginfo-0.8-3.fc18.x86_64.rpm \
          abuse-0.8-3.fc18.src.rpm
abuse.x86_64: W: spelling-error %description -l en_US fullscreen -> full
screen, full-screen, firescreen
abuse.x86_64: W: invalid-license redistributable
abuse.x86_64: E: incorrect-fsf-address /usr/share/doc/abuse-0.8/COPYING.GPL
abuse-debuginfo.x86_64: W: invalid-license redistributable
abuse.src: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
abuse.src: W: invalid-license redistributable
3 packages and 0 specfiles checked; 1 errors, 5 warnings.


+ OK
! needs attention

+ rpmlint errors/warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The license isn't suitable for Fedora, but is fine for rpmfusion nonfree
+ The license field in the spec file matches the actual license
+ The package contains the license files (COPYING, COPYING.GPL, COPYING.WTFPL)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  ec678b8dc8d00e0382d8c805c6438489  abuse-0.8.tar.gz
  ec678b8dc8d00e0382d8c805c6438489  Download/abuse-0.8.tar.gz
+ The package builds fine
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ The spec file handles locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
+ Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Looks good!

APPROVED

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.