[Bug 2809] Review request: copy-agent - Copy.com sync agent

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2809

--- Comment #1 from Ken Dreyer <ktdreyer at ktdreyer.com> 2013-05-22 17:04:32 CEST ---
Welcome to RPM Fusion, and thanks for your submission.

There are a couple things I'd like to note. The first thing to address is that
ordinarily we ask people to host files at URLs that we can directly access, ie
with curl or wget. Unfortunately Copy.com is prompting me to log into it in
order to download your files.

https://www.copy.com/s/GQzm9EKjKONZ/rpms/copy-agent.spec
https://www.copy.com/browse/s/GQzm9EKjKONZ/rpms/copy-agent-1.28.0657-1.fc18.src.rpm

To confirm, please run "curl -I" on those URLs, and you'll see the 302 Redirect
to a login URL. Please try to make these files available for download directly.

I did sign up with a throwaway account in order to look at your files.

The second thing to note is that you should use the rpmlint tool to examine
your RPMs, SRPM, and spec file. For example:

$ rpmlint /tmp/copy-agent-1.28.0657-1.fc18.src.rpm
copy-agent.src: E: no-changelogname-tag
copy-agent.src: W: invalid-license NON-OSI-COMPLIANT
copy-agent.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line
18)
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

This tool shows three things to fix.

The third thing to address is whether or not Copy.com allows us to redistribute
this tarball and associated files at all. I can find no information about a
license or terms of distribution. Just because the files are hosted on the web
somewhere doesn't mean we (as a third party) are allowed to distribute them,
even in RPM Fusion's non-free repo. If we can't have written authorization to
redistribute, we can't ship this in RPM Fusion. Do you have any links or emails
from Copy.com demonstrating that RPM Fusion is allowed to redistribute this
software?

The fourth thing is that you'll likely want to remove the EL5 compatibility
bits. RHEL 5 contains a very old version of RPM, so if you want to build on
RHEL 5, you have to include some extra bits of code in your spec files. The two
old bits I see in your .spec are "%defattr(-,root,root,-)" lines in %files and
the BuildRoot: setting. Neither of these settings are necessary in EL6 or
Fedora, so it makes sense to delete them.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.