[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #43 from Giles Birchley <gbirchley at blueyonder.co.uk> 2013-05-27 15:30:34 CEST ---
Hi everyone, thanks for your input, apologies for the delay in picking things
up.

I've now posted a new spec file here:
http://forums.pcsx2.net/attachment.php?aid=44388

and src rpm here:  http://forums.pcsx2.net/attachment.php?aid=44389

I've added the patch that Gregory posted so it should build for f19, although
since mock does not yet have a config file for f19 rpmfusion nonfree, I have
not tested the build in Fedora 19.

I've also addressed these comments, except for the last one...

"Quick notes:
- Please use libGL-devel/libGLU-devel instead of mesa-libGL-devel
- Please Remove BuildRequires: libCg (redundant with Cg)
- Use %{_prefix} instead of /usr for CMAKE install prefix
- Use -DCMAKE_BUILD_TYPE=ReleaseWithDebInfo that will build with fedora
CFLAGS."


ReleaseWithDebInfo is not a build option in pcsx2, but as discussed earlier in
this thread I have used -DCMAKE_BUILD_STRIP=FALSE , which produces the same
result.

rpmlint on the spec and src.rpm files gives:

$ rpmlint pcsx2.spec
pcsx2.spec:138: W: macro-in-%changelog %{_prefix}
pcsx2.spec:140: W: macro-in-%changelog %files
pcsx2.spec:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
pcsx2.spec: W: invalid-url Source0: pcsx2-linux_source-1.0.0-rev5412.tar.gz
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint pcsx2-1.0.0-1.fc18.src.rpm
pcsx2.src:138: W: macro-in-%changelog %{_prefix}
pcsx2.src:140: W: macro-in-%changelog %files
pcsx2.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
pcsx2.src: W: invalid-url Source0: pcsx2-linux_source-1.0.0-rev5412.tar.gz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


Nicholas Chauvet has emailed to ask that I apply for cvsextras; I now have an
account that can be dedicated to this but think I cannot apply for cvsextras
until the package review is completed, let me know if this is incorrect!

Many thanks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.