[Bug 3043] Review request: lfp-flash-plugin - Adobe Flash Player package bootstrap

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3043

--- Comment #6 from Alec Leamas <leamas.alec at gmail.com> 2013-11-26 12:16:46 CET ---
First review look into this: 

- The lpf spec needs a new scriptlet (upstream lpf fixes):

%triggerpostun -- %{target_pkg}
lpf scan-removal %{target_pkg} &>/dev/null || :

- Wouldn't it be possible for the x86_64 variant to include both the i386 and
the x86_64 stuff (Nicholas remark)?. Thinking about it, the x86_64 could
download both sources and augment the x86_64 installation with the i386 plugin.
The only conflict I see in the filelist is flash-player-properties; the 32-bit
variant could be installed as flash-player-properties32 in the x86_64 case if
required. Couldn't all this be done just by updating the spec, without any lpf
changes?

- Please add info about target package being i386/x86_64 only to description
(Nicholas remark).

- The lpf package MIT license is basically fine, we cannot use the target
package license, it's not re-distributable (Nicholas' remark). Please add info
on the target license to the description.

- I understand the reasons for using an epoch. While there was other
alternatives before this spec, it's now in use and I think it's reasonable to
provide a sane upgrade path for existing users i. e., please bump the epoch.

- The icons paths in %files could be simplified using a wildcard:
%{_datadir}/icons/hicolor/*/apps/flash-player-properties.png

- Please add the -a flag to cp in %install to preserve timestamps

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.