[Bug 3043] Review request: lfp-flash-plugin - Adobe Flash Player package bootstrap

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3043

--- Comment #8 from Simone Caronni <negativo17 at gmail.com> 2013-11-26 14:22:36 CET ---
(In reply to comment #6)
> - The lpf spec needs a new scriptlet (upstream lpf fixes):
> 
> %triggerpostun -- %{target_pkg}
> lpf scan-removal %{target_pkg} &>/dev/null || :

Ok, I've added it and also added to the lpf-skype package.

> - Please add info about target package being i386/x86_64 only to description
> (Nicholas remark).

Done.

> - The lpf package MIT license is basically fine, we cannot use the target
> package license, it's not re-distributable (Nicholas' remark). Please add info
> on the target license to the description.

This is already in the description:

"Bootstrap package allowing the lpf system to build the non-redistributable
flash-plugin package."

> - I understand the reasons for using an epoch. While there was other
> alternatives before this spec, it's now in use and I think it's reasonable to
> provide a sane upgrade path for existing users i. e., please bump the epoch.

I've seen only Epoch 0 used (official adobe repo and RHEL supplementary
channel); so I think unless someone installed the Epoch 1 package from me they
will have an Epoch 0 package installed. Should I bump it anyway? I find it
useless.

> - The icons paths in %files could be simplified using a wildcard:
> %{_datadir}/icons/hicolor/*/apps/flash-player-properties.png
> 
> - Please add the -a flag to cp in %install to preserve timestamps

Done.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.