[Bug 2921] Review request: openmw - Unofficial open source engine re-implementation of the game Morrowind

RPM Fusion Bugzilla noreply at rpmfusion.org
Sun Sep 15 14:08:26 CEST 2013


https://bugzilla.rpmfusion.org/show_bug.cgi?id=2921

--- Comment #19 from Richard <hobbes1069 at gmail.com> 2013-09-15 14:08:26 CEST ---
Ok, I missed a couple of other things :)

1. I forgot to bump the actual release tag at the top of the spec after fixing
them in the changelog.

2. You need to change this part of %files:

%{_datadir}/%{name}/resources/materials/
%{_datadir}/%{name}/resources/mygui/
%{_datadir}/%{name}/resources/water/

When you do this, RPM only grabs and owns the last directory of each line.
Since the guidelines say that packages must own directories they create then:
%{_datadir}/%{name}
%{_datadir}/%{name}/resources

Need to be owned by the package as well. You could add two entries with %dir to
do this but the simplest solution is to replace all 3 with:

%{_datadir}/%{name}/

That way it will own /usr/share/openmw and everything under it. There's no real
advantage to specifying the the others separately anyway. Usually the only time
I worry about that is with binaries and libraries because upstream can
add/remove things and just grabbing everything, you wouldn't know the
difference.

I'm also toying with adding an empty /usr/share/openmw/data. Do you think it
will look for the data files there? That seems cleaner than a wine install.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the rpmfusion-developers mailing list