[Bug 3443] Review request: nemo-dropbox - Dropbox extension for nemo

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3443

--- Comment #2 from Wolfgang Ulbrich <chat-to-me at raveit.de> 2014-12-09 19:46:33 CET ---
Ok, package builds fine in rawhide.

Must:
1. Licence field have to adjust.

[ ]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "GPL (v2 or later)", "GPL (v3 or
     later)", "Unknown or generated", "MIT/X11 (BSD like)", "GPL (v2 or later)
     (with incorrect FSF address)", "LGPL (v2.1 or later)". 39 files have
     unknown license. Detailed output of licensecheck in /home/rave/nemo-
     dropbox/licensecheck.txt

Should:

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

AutoTools: Obsoleted m4s found
------------------------------
  AM_PROG_LIBTOOL found in: /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-seahorse/configure.ac:27, /home/rave/nemo-
  dropbox/upstream-unpacked/Source0/nemo-extensions-2.4.x/nemo-
  fileroller/configure.ac:20, /home/rave/nemo-dropbox/upstream-
  unpacked/Source0/nemo-extensions-2.4.x/nemo-dropbox/configure.in:20
  AC_PROG_LIBTOOL found in: /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-repairer/configure.ac:10, /home/rave/nemo-
  dropbox/upstream-unpacked/Source0/nemo-extensions-2.4.x/nemo-
  preview/configure.ac:38, /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-image-converter/configure.ac:14, /home/rave
  /nemo-dropbox/upstream-unpacked/Source0/nemo-extensions-2.4.x/nemo-
  share/configure.in:17, /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-python/configure.in:20
  AM_CONFIG_HEADER found in: /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-seahorse/configure.ac:10, /home/rave/nemo-
  dropbox/upstream-unpacked/Source0/nemo-extensions-2.4.x/nemo-
  fileroller/configure.ac:9, /home/rave/nemo-dropbox/upstream-unpacked/Source0
  /nemo-extensions-2.4.x/nemo-dropbox/configure.in:9, /home/rave/nemo-dropbox
  /upstream-unpacked/Source0/nemo-extensions-2.4.x/nemo-python/configure.in:11

But i think this is a job for upstream and we can ignore it because the package
builds fine in rawhide.

2. You should inform upstream about incorrect FSF address, see licencecheck

rpmlint:

Checking: nemo-dropbox-2.4.x-1.fc22.x86_64.rpm
          nemo-dropbox-2.4.x-1.fc22.src.rpm
nemo-dropbox.x86_64: W: self-obsoletion nautilus-dropbox obsoletes
nautilus-dropbox
nemo-dropbox.src: W: strange-permission nemo-extensions-2.4.x.tar.gz 0444L
nemo-dropbox.src:26: W: unversioned-explicit-obsoletes nautilus-dropbox
nemo-dropbox.src:27: W: unversioned-explicit-provides nautilus-dropbox
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Please adjust permission of the tarball.
I'm not really shure about self-obsoletion. Maybe this is the result of
unversioned-explicit-obsoletes/provides.
Anyway you can't use a version for it.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.