[Bug 3345] Review request: kodi - Media center

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345

--- Comment #16 from Jonathan Dieter <jdieter at gmail.com> 2014-12-29 09:34:39 CET ---
(In reply to comment #13)
> (In reply to comment #12)
> > That's great, but I think it would be good to actually remove them from the
> > generated source tree, if for no other reasons than to guarantee that they
> > aren't being built.
> 
> The Kodi build system expects the autotools files to be present even if we're
> not compiling them. I'd rather not patch the autotools files as these will
> constantly change. This is different from the past (pre-Kodi) where we could
> drop the code.
> 
> > Maybe not, but the libraries are multi-lib.  If, for some strange reason, I
> > have libcec.i686 installed, but not libcec.x86_64, installing kodi won't bring
> > in libcec.x86_64.  The manual requires need to have arched-Requires.
> 
> For the sake of getting this reviewed I've changed them.

Thank you.  This looks good.

> > Apart from all that, do you have thoughts on the man pages and the ExcludeArch?
> 
> The ExcludeArch stays. Upstream does not support it. The man pages have been
> moved.

Ok.  Thanks for moving the man pages

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.