[Bug 3095] Review request: netfabb-basic - Freeware suite for STL editing

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3095

Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com

--- Comment #2 from Richard <hobbes1069 at gmail.com> 2014-01-08 15:14:28 CET ---
Redistributable seems to be correct based on the provided LICENSE file. It
looks like it bundles some sort of unzip library. I'm not sure how to check to
see if this is the same as the fedora library, if so, it would require a
bundling exception (to my knowledge the non-free repository is not exempt from
this).

Quick spec review:

1. All the echos for the desktop file is messy. Use this method instead:
cat >%{buildroot}%{_datadir}/applications/%{name}.desktop <<EOL
line 1
line 2 
line 3
line 4
... 
EOL

2. Use install instead of cp to install the binary and libraries so you don't
have to fix it in %files:
install -pm 0755 netfabb %{buildroot}%{_bindir}/%{name}
install -pm 0755 *.so.* %{buildroot}%{_libdir}

I'm not sure if install works with wildcards but worth a shot. Worst case you
do them individually.

3. %check is for any unit tests that the project can run against itself to make
sure it functions, desktop-file-validate belongs in %install.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.