[Bug 3282] Review Request: x265 - H.265/HEVC encoder

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3282

Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org

--- Comment #2 from Xavier Bachelot <xavier at bachelot.org> 2014-07-10 13:56:24 CEST ---
(In reply to comment #1)
> x265-devel.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/x265-devel/doc/uncrustify/drag-uncrustify.bat
> ^ this is a Windows batch file, but might be useful as it shows the command
> line to use with uncrustify
> 
You can still fix the end of lines.

Then a few comments on the spec itself:
- You can use %{version} macro in source0 URL.
- No link to upstream bug reports for the patches.

Looks good otherwise from a cursory glance.

However, a mock build failed on a 32 bits host (not tested on 64 bits though) :
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.tDNt8m
+ umask 022
+ cd /builddir/build/BUILD
+ cd multicoreware-x265-d6257335c537
++ pwd
+ LD_LIBRARY_PATH=/builddir/build/BUILD/multicoreware-x265-d6257335c537
+ test/PoolTest
++ pwd
+ LD_LIBRARY_PATH=/builddir/build/BUILD/multicoreware-x265-d6257335c537
+ test/TestBench
/var/tmp/rpm-tmp.tDNt8m: line 32: 21860 Segmentation fault     
LD_LIBRARY_PATH=$(pwd) test/TestBench

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.