[Bug 3174] Review request: xbmc-pvr-addons - XBMC PVR add-ons

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3174

--- Comment #21 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2014-05-09 15:55:12 CEST ---
(In reply to comment #18)
> I took another look at this today, and here's the build failure I'm getting on
> Rawhide. Looks like there are some errors in Pvr2Wmc::SignalStatus due to
> https://fedorahosted.org/fesco/ticket/1185.
> 
> The command I ran was "fedora-review --other-bz https://bugzilla.rpmfusion.org/
> -b 3174 -m fedora-rawhide-x86_64-rpmfusion_free"
> 
> The patch at https://github.com/opdenkamp/xbmc-pvr-addons/pull/296 allows the
> package to build for me on Rawhide.
Fixed, thanks for the bug report ;)

(In reply to comment #19)
> Please add extra percent signs to escape the macros and silence the warnings:
> 
>   xbmc-pvr-addons.src:6: W: macro-in-comment %{commit}
>   xbmc-pvr-addons.src:8: W: macro-in-comment %{commit_date}
>   xbmc-pvr-addons.src:8: W: macro-in-comment %{short_commit}
Fixed


> Please add "Provides: bundled(md5-plumb)", since addons/pvr.nextpvr/src/md5.cpp
> bundles this md5 implementation
> (https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries)
Fixed

> From what I understand, the License field should be "LGPLv2.1 and GPLv2 and
> GPLv2+", since different plugins are under different licenses (and some bits,
> eg cmyth, are even a combination of LGPL and GPL).
Fixed

> For this part:
> 
>   # Delete useless files
>   rm $RPM_BUILD_ROOT%{_datadir}/xbmc/addons/*/*.in
> 
> What .in files is make installing? That sounds like it should be reported and
> fixed upstream.
For almost all plugins, the addon template file addon.xml.in is deployed. I
will report this issue upstream.

(In reply to comment #20)
> There is also a bundled sha1 implementation at lib/libhts/sha1.c. Please
> determine if this is built as part of the binaries, and if so, add the
> appropriate Provides.
Fixed

Spec URL:
http://pikachu.2014.free.fr/public/packages/xbmc-pvr-addons/xbmc-pvr-addons.spec
SRPM URL:
http://pikachu.2014.free.fr/public/packages/xbmc-pvr-addons/xbmc-pvr-addons-13.0-0.4.Gotham_rc1.fc20.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.