[Bug 3174] Review request: xbmc-pvr-addons - XBMC PVR add-ons

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3174

--- Comment #25 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2014-05-24 16:20:41 CEST ---
(In reply to comment #22)
> - Please add "GPLv3" to the list of licenses, since that is what is declared in
>   the root "COPYING" file.
Done

> - We need to ensure that every sub-package installation will result in an
>   installation of the root COPYING file. I think the best way to handle this
>   would be to put the root COPYING file into a "xbmc-pvr-addons" package, and
>   have each sub-package "Requires: %{name}%{?_isa} = %{version}-%{release}". (I
>   could be wrong, but I don't think it's possible to have the parent package be
>   noarch.)
I added a common subpackage which contain the licenses. Such a package may be
useful too to manage (possible) deletions of some plugins in the future.

> - Since there are multiple licenses, please provide a summary of "what is
>   licensed under what" in a comment above the "License" field. Here's what I
>   recommend adding as a comment:
Done

> - Each patch should include a comment about whether or not this can go
>   upstream. If it has been provided to upstream, then the patch should include
>   a link to the submission upstream. For example, Patch5 should have a comment
>   with a link to https://github.com/opdenkamp/xbmc-pvr-addons/pull/296.
Done

> - Please delete the zero-length m3u file during %prep, and include a link to
>   https://github.com/opdenkamp/xbmc-pvr-addons/pull/298
Done

> - Please report the issue with incorrect permissions upstream, and include a
>   link to that report along with your "Fix permissions" comment.
Done (see https://github.com/opdenkamp/xbmc-pvr-addons/pull/303)

> - Please report the addons.xml.in issue upstream, since that ought to be fixed
>   in upstream's make files. Please include a link to that report along with
>   your "Delete useless files" comment.
Done (see https://github.com/opdenkamp/xbmc-pvr-addons/pull/301)

> - Please submit a report upstream to switch AC_PROG_LIBTOOL in configure.ac to
>   LT_INIT (https://fedorahosted.org/FedoraReview/wiki/AutoTools). Even better
>   if it's a pull request (that you've tested yourself :)
Done (and obviously tested :), see
https://github.com/opdenkamp/xbmc-pvr-addons/pull/302)

(In reply to comment #23)
> Also: Upstream released a 13.0 final version.
Done

Notice that the VNSI server plugin for VDR is no longer part of the PVR addons
sources; it's now a separate project. The corresponding package is available in
Fedora (http://koji.fedoraproject.org/koji/packageinfo?packageID=18556). As a
result, I dropped it in my packaging too.

Spec URL:
http://pikachu.2014.free.fr/public/packages/xbmc-pvr-addons/xbmc-pvr-addons.spec
SRPM URL:
http://pikachu.2014.free.fr/public/packages/xbmc-pvr-addons/xbmc-pvr-addons-13.0-1.fc20.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.