[Bug 3251] Review request: vdr-xineliboutput - xine-lib based software output device for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3251

--- Comment #10 from MartinKG <mgansser at alice.de> 2014-05-26 18:54:35 CEST ---
(In reply to Antonio Trande from comment #8)
> mkdir -p libdir/usr/lib/plugin/vdr
> 
> Why do you create this directory?

I took this from the existing spec file.
removed it

(In reply to Antonio Trande from comment #9)
> - Please, use  CFLAGS="-I%{includedir}/ffmpeg" \
> 
> - /usr/lib64/vdr is already owned by vdr/vdr-devel.
>   Remove the line 
> %dir %{vdr_plugindir}

done
> - Remove 
> %defattr(-,root,root,-)

done
> - Why use %define?
> 
> %define         build_cvs   1
> %if 0%{?build_cvs}
>     %define cvsver 20140429
> %endif

I took this from the existing spec file.
removed it.


Spec URL:
https://www.dropbox.com/s/wjqwbfwuttzey5m/vdr-xineliboutput.spec

SRPM URL:
http://martinkg.fedorapeople.org/Review/SRPMS/vdr-xineliboutput-1.1.0-5.cvs20140429.fc20.src.rpm

%changelog
* Mon May 26 2014 Martin Gansser <martinkg at fedoraproject.org> -
1.1.0-5.cvs20140429
- removed unused libdir path
- replaced hardlink path in CFLAGS by macro
- removed %%dir %%{vdr_plugindir} already owned by vdr/vdr-devel
- removed macro %%defattr from file section
- removed extra flag for building cvs build

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.