[Bug 3251] Review request: vdr-xineliboutput - xine-lib based software output device for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3251

--- Comment #14 from Antonio Trande <anto.trande at gmail.com> 2014-05-27 15:42:35 CEST ---
(In reply to comment #12)
> (In reply to Nicolas Chauvet from comment #11)
> > (In reply to comment #10)
> > > (In reply to Antonio Trande from comment #9)
> > > > - Please, use  CFLAGS="-I%{includedir}/ffmpeg" \
> > Please don't harcode the ffmpeg cflags. You need to use pkgconfig and pass the
> > FFMPEG_CFLAGS as needed when building the code using it.
> 
> i don't know if this is the correct command, i where should i place this ?
> 
> # FFMPEG_CFLAGS=`pkg-config --cflags libavcodec libavdevice libavfilter
> libavformat libavutil libpostproc libswscale`
> # echo $FFMPEG_CFLAGS
> -I/usr/include/ffmpeg

1. Try

...
%prep
%setup -q -n %{name}-%{version}%{?cvsver:-%{cvsver}}

./configure \
    --enable-x11 \
    --enable-fb \
    --enable-vdr \
    --enable-libxine  \
    --debug \
%if !%{have_bluray}
    --disable-libbluray \
%endif
    VDRDIR=%{vdr_plugindir} \
    VDRINCDIR=%{_includedir} \
    LOCALEDIR=./locale \
    DESTDIR=%{buildroot} \
    LIBDIR=%{_libdir} \
    XINELIBOUTPUT_FB=1 \
    XINELIBOUTPUT_X11=1 \
    XINELIBOUTPUT_VDRPLUGIN=1 \
    XINELIBOUTPUT_XINEPLUGIN=1

%build
FFMPEG_CFLAGS="$FFMPEG_CFLAGS $(${cross_prefix}pkg-config --cflags libavformat
libavcodec libswscale libavutil)"
export=FFMPEG_CFLAGS 
make CFLAGS="%{optflags} -fPIC $FFMPEG_CFLAGS" CXXFLAGS="%{optflags} -fPIC
$FFMPEG_CFLAGS" %{?_smp_mflags} all

2. About the warnings

vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-fbfe.so.2.0.6
libxineliboutput-fbfe.so.2.0.6-cvs
vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-sxfe.so.2.0.6
libxineliboutput-sxfe.so.2.0.6-cvs

Symbolic links seem wrong
-rwxr-xr-x. 1 sagitter sagitter 565304 May 26 20:09
libvdr-xineliboutput.so.2.0.6
-rwxr-xr-x. 1 sagitter sagitter  73520 May 26 20:09
libxineliboutput-fbfe.so.2.0.0-cvs
lrwxrwxrwx. 1 sagitter sagitter     34 May 26 20:09
libxineliboutput-fbfe.so.2.0.6 -> libxineliboutput-fbfe.so.2.0.6-cvs
-rwxr-xr-x. 1 sagitter sagitter 122968 May 26 20:09
libxineliboutput-sxfe.so.2.0.0-cvs
lrwxrwxrwx. 1 sagitter sagitter     34 May 26 20:09
libxineliboutput-sxfe.so.2.0.6 -> libxineliboutput-sxfe.so.2.0.6-cvs

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.