[Bug 3251] Review request: vdr-xineliboutput - xine-lib based software output device for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3251

--- Comment #18 from Antonio Trande <anto.trande at gmail.com> 2014-05-28 15:53:16 CEST ---
- Replace LIBDIR=%{_libdir} to --libdir=%{_libdir}

- Remove DESTDIR=%{buildroot} and %defattr(-,root,root,-)

- '/etc/vdr' (or %{vdr_configdir}) and '/etc/vdr/plugins' are directories
already owned by
  'vdr' package. Main package needs 'vdr' as Requires.

- 'vdr-xineliboutput-plugin' puts 'allowed_hosts.conf' in a directory owned by
'vdr-xineliboutput', 
  but 'vdr-xineliboutput-plugin' doesn't require 'vdr-xineliboutput'.

  Probably

%package plugin
Summary:        Plugins for watching VDR over Xine
Group:          Applications/Multimedia
License:        GPLv2+
Requires:       vdr(abi)%{?_isa} = %{vdr_apiversion}
Provides:       libxineliboutput-fbfe.so = %{version}
Provides:       libxineliboutput-sxfe.so = %{version}

must be 

%package plugin
Summary:        Plugins for watching VDR over Xine
Group:          Applications/Multimedia
License:        GPLv2+
Requires:       %{name}%{?_isa} = %{version}-%{release}
Provides:       libxineliboutput-fbfe.so = %{version}
Provides:       libxineliboutput-sxfe.so = %{version}

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.