[Bug 2429] Review request: gens-gs - Sega Genesis, Sega CD, and Sega 32X emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429

--- Comment #8 from Jeremy Newton <alexjnewt at gmail.com> 2014-10-05 20:47:35 CEST ---
Thanks!

(In reply to comment #7)
> Do you have a Fedora FAS or RPMFusion FAS account? What is your user name?

My Fas username is mystro256, my rpmfusion fas is jem256

> Issues:
> =======
>   (Please delete all libtool files)
Makes sense, will do!

> - Large documentation must go in a -doc subpackage. Large could be size (~1MB)
>   or number of files.
>   Note: Documentation size is 1884160 bytes in 99 files.
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
>   (Could you use %doc for README and license files?)
Nice catch,I'll include a doc package

> - License field needs to reflect free and non-free licensed pieces
>   (MIT, BSD, and a non-free license were found)
Hmm indeed I forgot to check this

> - Conflicts with "gens" - will you retire "gens" or patch this package to not
>   conflict with it?
Unfortunately the maintainer of gen has no interest in retiring the package,
but yes if a conflict must be avoided, I'll patch it to not conflict with gens

> [-]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.
I believe they're not, let me check to make sure.

> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by: /usr/share/gens(gens)
Will fix if conflict free is necessary

> Generic:
> [!]: Package should not use obsolete m4 macros
>      Note: Some obsoleted macros found, see the attachment.
>      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
Makes sense will do

> [!]: Large data in /usr/share should live in a noarch subpackage if package is
>      arched.
>      Note: Arch-ed rpms have a total of 1996800 bytes in /usr/share
I take this is the doc files? If so, its an easy fix

> gens-gs.src:46: W: configure-without-libdir-spec
Do you know what causes this? I'm unformillar with this rpmlint warning
Is this the libtool issue with configure.ac?

> Unversioned so-files
> --------------------
> gens-gs: /usr/lib/mdp/mdp_misc_game_genie.so
> gens-gs: /usr/lib/mdp/mdp_misc_ips_patcher.so
> gens-gs: /usr/lib/mdp/mdp_misc_sgens.so
> gens-gs: /usr/lib/mdp/mdp_misc_vdp_layer_options.so
> gens-gs: /usr/lib/mdp/mdp_render_2xsai.so
> gens-gs: /usr/lib/mdp/mdp_render_blargg_ntsc.so
> gens-gs: /usr/lib/mdp/mdp_render_epx.so
> gens-gs: /usr/lib/mdp/mdp_render_epx_plus.so
> gens-gs: /usr/lib/mdp/mdp_render_hq2x.so
> gens-gs: /usr/lib/mdp/mdp_render_hq3x.so
> gens-gs: /usr/lib/mdp/mdp_render_hq4x.so
> gens-gs: /usr/lib/mdp/mdp_render_interpolated.so
> gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline.so
> gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_25.so
> gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_50.so
> gens-gs: /usr/lib/mdp/mdp_render_scale2x.so
> gens-gs: /usr/lib/mdp/mdp_render_scale3x.so
> gens-gs: /usr/lib/mdp/mdp_render_scale4x.so
> gens-gs: /usr/lib/mdp/mdp_render_scanline.so
> gens-gs: /usr/lib/mdp/mdp_render_scanline_25.so
> gens-gs: /usr/lib/mdp/mdp_render_scanline_50.so
> gens-gs: /usr/lib/mdp/mdp_render_super_2xsai.so
> gens-gs: /usr/lib/mdp/mdp_render_super_eagle.so
Do you think moving these will be necessary?


Thanks again for the review!

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.