[Bug 3356] Review Request: pipelight - NPAPI Wrapper Plugin for using Windows plugins in Linux browsers

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3356

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |4

--- Comment #3 from Hans de Goede <j.w.r.degoede at gmail.com> 2014-09-23 16:04:17 CEST ---
Already reviewed in Fedora, still doing a quick re-review for good measure.

Good:
- rpmlint checks return:
pipelight-common.noarch: W: dangling-symlink /usr/share/pipelight/wine
/usr/bin/wine
pipelight-common.noarch: W: dangling-symlink /usr/share/pipelight/wine64
/usr/bin/wine64
pipelight-common.noarch: W: dangerous-command-in-%post cp
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
 These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+ or LGPLv2+ or MPLv1.1) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Everything looks good: approved.

Please create an account in rpmfusion's fas:
http://rpmfusion.org/Contributors#Get_an_RPM_Fusion_Account

And once that is done file a CVS admin request:
http://rpmfusion.org/Contributors#Your_package_gets_approved

Note that rpmfusion still uses the old CVS and plague as they were used in
Fedora in the old days, we are working on moving over to git / koji, but there
is no ETA for that. In the mean time see:

http://rpmfusion.org/Contributors

For CVS & build instructions.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.