[Bug 3740] Review request: gstreamer1-plugins-bad-nonfree - GStreamer 1.0 streaming media framework "bad" non-free plug-ins

RPM Fusion Bugzilla noreply at rpmfusion.org
Sat Aug 22 13:02:48 CEST 2015 

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3740

--- Comment #1 from leigh scott <leigh123linux at gmail.com> 2015-08-22 13:02:48 CEST ---
Created attachment 1474
  --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1474
buildlog

APPROVED

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0) LGPL", "LGPL (v2 or later)", "GPL (v2 or
     later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD
     like) LGPL (v2 or later) (with incorrect FSF address)", "MIT/X11 (BSD
     like)", "MIT/X11 (BSD like) LGPL (v2 or later)", "MPL (v1.1)", "LGPL
     (v2 or later) (with incorrect FSF address)", "MPL (v1.1) LGPL (v2 or
     later)", "*No copyright* LGPL (v2 or later)", "BSL", "ISC", "MPL
     (v1.1) GPL (v2 or later) GPL (v2 or later) LGPL (v2 or later)",
     "LGPL", "LGPL (v2.1 or later) (with incorrect FSF address)", "BSD (3
     clause)", "BSD (2 clause)", "LGPL (v2.1 or later)", "*No copyright*
     GPL (v3 or later)". 66 files have unknown license. Detailed output of
     licensecheck in /home/leigh/Desktop/gstreamer1-plugins-bad-
     nonfree/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[?]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: gstreamer1-plugins-bad-nonfree-1.4.5-1.fc22.x86_64.rpm
          gstreamer1-plugins-bad-nonfree-1.4.5-1.fc22.src.rpm
gstreamer1-plugins-bad-nonfree.x86_64: W: spelling-error Summary(en_US)
GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-nonfree.x86_64: W: spelling-error %description -l en_US
GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-nonfree.src: W: spelling-error Summary(en_US) GStreamer
-> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-nonfree.src: W: spelling-error %description -l en_US
GStreamer -> G Streamer, Streamer, Steamer
2 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (debuginfo)
-------------------
Checking: gstreamer1-plugins-bad-nonfree-debuginfo-1.4.5-1.fc22.x86_64.rpm
gstreamer1-plugins-bad-nonfree-debuginfo.x86_64: E: description-line-too-long C
This package provides debug information for package
gstreamer1-plugins-bad-nonfree.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
gstreamer1-plugins-bad-nonfree.x86_64: W: spelling-error Summary(en_US)
GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-nonfree.x86_64: W: spelling-error %description -l en_US
GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-nonfree-debuginfo.x86_64: E: description-line-too-long C
This package provides debug information for package
gstreamer1-plugins-bad-nonfree.
2 packages and 0 specfiles checked; 1 errors, 2 warnings.



Requires
--------
gstreamer1-plugins-bad-nonfree (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libfaac.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgstaudio-1.0.so.0()(64bit)
    libgstbase-1.0.so.0()(64bit)
    libgstpbutils-1.0.so.0()(64bit)
    libgstreamer-1.0.so.0()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
gstreamer1-plugins-bad-nonfree:
    gstreamer1(element-faac)()(64bit)
    gstreamer1(encoder-audio/mpeg)(mpegversion=2)()(64bit)
    gstreamer1(encoder-audio/mpeg)(mpegversion=4)()(64bit)
    gstreamer1-plugins-bad-nonfree
    gstreamer1-plugins-bad-nonfree(x86-64)
    libgstfaac.so()(64bit)



Unversioned so-files
--------------------
gstreamer1-plugins-bad-nonfree: /usr/lib64/gstreamer-1.0/libgstfaac.so

Source checksums
----------------
http://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.4.5.tar.xz
:
  CHECKSUM(SHA256) this package     :
152fad7250683d72f9deb36c5685428338365fe4a4c87ffe15e38783b14f983c
  CHECKSUM(SHA256) upstream package :
152fad7250683d72f9deb36c5685428338365fe4a4c87ffe15e38783b14f983c


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -v -m fedora-22-x86_64-rpmfusion_nonfree
--rpm-spec -n gstreamer1-plugins-bad-nonfree-1.4.5-1.fc19.src.rpm
Buildroot used: fedora-22-x86_64

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the rpmfusion-developers mailing list