[Bug 3429] Review request: frobtads - Text interpreter for Tads games

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3429

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4

--- Comment #4 from Hans de Goede <j.w.r.degoede at gmail.com> 2015-12-29 13:08:11 CET ---
Hi,

(In reply to comment #3)
> > -Why is %{_datadir}/frobtads/tads2 owned by the -devel pkg and not by the main
> > pkg ?
> 
> These files are include files used only by Tads 2 compiler. I placed header
> files and the compilers (+ the TADS includes) into the -devel subpackage.
> 
> On other hand, tads3/res/charmap/cmaplib.t3r is needed for runtime and in the
> main package.

Ok, thanks for the explanation. 

> Updated version:
> 
> Spec URL: http://scientific.zcu.cz/fedora/frobtads-1.2.3-1b/frobtads.spec
> SRPM URL:
> http://scientific.zcu.cz/fedora/frobtads-1.2.3-1b/frobtads-1.2.3-1.fc24.src.rpm

Looks good now. Next time you do a new version for a pkg-review please bump the
release field and at a changelog with the changes you made, just like you would
do in a Fedora pkg review. No need to respin for that now.

This package is approved.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.