[Bug 3539] Review Request: kwave - Sound Editor for KDE

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3539

--- Comment #3 from MartinKG <mgansser at alice.de> 2015-02-09 15:12:39 CET ---
Hi Mario,

this is not a offical review.
1. Rpmlint says:

 rpmlint kwave-0.8.99-6.fc21.x86_64.rpm
kwave.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmag.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmagfit.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_loop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause_2.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_record.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_stop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_fwd.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_start.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_end.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_in.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/kwave.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_rew.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_original.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_out.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz

Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

a possible fix:

# Fix gzipped-svg-icon
(
cd %{buildroot}%{_datadir}/icons/hicolor/scalable/actions
zcat kwave_viewmag.svgz > kwave_viewmag.svg && rm -f kwave_viewmag.svgz
zcat kwave_viewmagfit.svgz > kwave_viewmagfit.svg && rm -f
kwave_viewmagfit.svgz
zcat kwave_player_loop.svgz > kwave_player_loop.svg && rm -f
kwave_player_loop.svgz
zcat kwave_player_pause_2.svgz > kwave_player_pause_2.svg && rm -f
kwave_player_pause_2.svgz
zcat kwave_player_record.svgz > kwave_player_record.svg && rm -f
kwave_player_record.svgz
zcat kwave_player_stop.svgz > kwave_player_stop.svg && rm -f
kwave_player_stop.svgz
zcat kwave_player_fwd.svgz > kwave_player_fwd.svg && rm -f
kwave_player_fwd.svgz
zcat kwave_player_pause.svgz > kwave_player_pause.svg && rm -f
kwave_player_pause.svgz
zcat kwave_player_start.svgz > kwave_player_start.svg && rm -f
kwave_player_start.svgz
zcat kwave_player_end.svgz > kwave_player_end.svg && rm -f
kwave_player_end.svgz
zcat kwave_zoom_in.svgz > kwave_zoom_in.svg && rm -f kwave_zoom_in.svgz
zcat kwave_player_rew.svgz > kwave_player_rew.svg && rm -f
kwave_player_rew.svgz
zcat kwave_zoom_original.svgz > kwave_zoom_original.svg && rm -f
kwave_zoom_original.svgz
zcat kwave_zoom_out.svgz > kwave_zoom_out.svg && rm -f kwave_zoom_out.svgz
zcat kwave_player_play.svgz > kwave_player_play.svg && rm -f
kwave_player_play.svgz
cd %{buildroot}%{_datadir}/icons/hicolor/scalable/apps
)

2.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
     "BSD (2 clause) GPL (v2 or later)", "Unknown or generated". 2 files have
     unknown license.

should be: GPLv2+ and BSD and not GPLv2+ and CC-BY-SA

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.