[Bug 3492] Review request: mp3splt - Command line program from the mp3splt-project

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3492

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann at gmail.com> 2015-02-16 10:40:41 CET ---
Some initial comments:

BuildRequires:    libmp3splt = 0.9.2, libmp3splt-devel = 0.9.2

Doesn't make sense. The libmp3splt library is pulled in by the according -devel
package anyway. Can be safely dropped from BuildRequires.


The license is GPLv2+ according to the licensecheck output:

$ licensecheck -r *
autogen.sh: *No copyright* UNKNOWN
src/options_manager.c: GPL (v2 or later)
src/options_checker.c: GPL (v2 or later)
src/windows_utils.c: GPL (v2 or later)
src/common.h: GPL (v2 or later)
src/data_manager.c: GPL (v2 or later)
src/windows_utils.h: GPL (v2 or later)
src/data_manager.h: GPL (v2 or later)
src/freedb.c: GPL (v2 or later)
src/print_utils.c: GPL (v2 or later)
src/options_parsers.c: GPL (v2 or later)
src/freedb.h: GPL (v2 or later)
src/options_parsers.h: GPL (v2 or later)
src/utils.c: GPL (v2 or later)
src/print_utils.h: GPL (v2 or later)
src/utils.h: GPL (v2 or later)
src/options_checker.h: GPL (v2 or later)
src/mp3splt.c: GPL (v2 or later)
src/options_manager.h: GPL (v2 or later)


Add "BuildRequires: gettext", otherwise build will fail.


The license file (COPYING) has to go in a separate directory apart from the
docs:

%license COPYING

See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
for more information.


NEWS is missing from %doc. Moreover, the doc subdirectory contains a HTML
version of the man page, should be worth also to be added to %doc.


%{_datadir}/locale/*/LC_MESSAGES/%{name}.mo

This is redundant, because you use the find_lang script anyway.


%{_mandir}/man1/%{name}.1.gz

Don't use a certain extension for man pages. The compression algorithm can
change in the future, better use a wildcard:

%{_mandir}/man1/%{name}.1.*


%changelog
* Mon Nov 17 2014 Thomas Vogt <admin at tovotu.de>

The changelog entries have to contain the version number and release tag:

%changelog
* Mon Nov 17 2014 Thomas Vogt <admin at tovotu.de> - 2.6.2-1

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.