[Bug 3485] girl - GNOME Internet Radio Locator
RPM Fusion Bugzilla
noreply at rpmfusion.org
Sun Jan 4 15:21:26 CET 2015
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485
--- Comment #1 from Antonio Trande <anto.trande at gmail.com> 2015-01-04 15:21:26 CET ---
I can just do a review of this package; you're a new packager in RPMFusion, so
you need a sponsor (see
http://rpmfusion.org/Contributors#Becoming_a_RPM_Fusion_contributor).
--- REVIEW ---
- Please, use --disable-silent-rules option with configure.
- '/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :'
in the line #39 is redundant. Remove it.
- Move the line '%find_lang %{name} --with-man' under %install section.
- Use
Release: 1%{?dist}
See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
- The package 'hicolor-icon-theme' owns '/usr/share/icons/hicolor' but doesn't
own '/usr/share/icons/hicolor/1024x1024' that's used and created by 'girl'.
For now, 'girl' should own '/usr/share/icons/hicolor/1024x1024' entirely
%{_datadir}/icons/hicolor/1024x1024/apps/girl.png
becomes
%{_datadir}/icons/hicolor/1024x1024/
However, you should inform the maintainer of 'hicolor-icon-theme' that your
package is using a new /usr/share/icons/hicolor/ sub-directory.
- /usr/share/girl directory is fully owned by 'girl'.
%{_datadir}/girl/girl-1.0.dtd
%{_datadir}/girl/girl-logo.png
%{_datadir}/girl/girl.png
%{_datadir}/girl/girl.xml
%{_datadir}/girl/pixmaps/girl-map.png
can be replaced with just
%{_datadir}/girl/
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- update-desktop-database is invoked in %post and %postun if package contains
desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in girl
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated".
2 files have unknown license. Detailed output of licensecheck in
/home/sagitter/review-girl/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/icons/hicolor/1024x1024/apps,
/usr/share/icons/hicolor/1024x1024, /usr/share/girl/pixmaps,
/usr/share/girl
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/girl/pixmaps,
/usr/share/icons/hicolor/1024x1024/apps,
/usr/share/icons/hicolor/1024x1024, /usr/share/girl
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in girl
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
===== SHOULD items =====
Generic:
[!]: Dist tag is present (not strictly required in GL).
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Test run failed
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: girl-1.0.0-1.i686.rpm
girl-1.0.0-1.src.rpm
girl.src: W: spelling-error %description -l en_US streamripper -> stream
ripper, stream-ripper, stripper
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root at localhost /]# rpmlint girl
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
]0;<mock-chroot><mock-chroot>[root at localhost /]# echo 'rpmlint-done:'
Requires
--------
girl (rpmlib, GLIBC filtered):
/bin/sh
libICE.so.6
libORBit-2.so.0
libSM.so.6
libart_lgpl_2.so.2
libatk-1.0.so.0
libbonobo-2.so.0
libbonobo-activation.so.4
libbonoboui-2.so.0
libc.so.6
libcairo.so.2
libfontconfig.so.1
libfreetype.so.6
libgconf-2.so.4
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libgio-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgnome-2.so.0
libgnomecanvas-2.so.0
libgnomeui-2.so.0
libgnomevfs-2.so.0
libgobject-2.0.so.0
libgthread-2.0.so.0
libgtk-x11-2.0.so.0
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libpopt.so.0
libpthread.so.0
libxml2.so.2
libxml2.so.2(LIBXML2_2.4.30)
libxml2.so.2(LIBXML2_2.6.0)
rtld(GNU_HASH)
streamripper
totem
Provides
--------
girl:
appdata()
appdata(girl.appdata.xml)
application()
application(girl.desktop)
girl
girl(x86-32)
mimehandler(application/girl)
Source checksums
----------------
http://girl.software/girl-1.0.0.tar.xz :
CHECKSUM(SHA256) this package :
db2371ac35994c21dcddf8ade0d20109ecd871e43a470f464edc97a5477da0bf
CHECKSUM(SHA256) upstream package :
db2371ac35994c21dcddf8ade0d20109ecd871e43a470f464edc97a5477da0bf
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-i386-rpmfusion_free -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the rpmfusion-developers
mailing list