[Bug 3693] Review request: girl - GNOME Internet Radio Locator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3693

--- Comment #5 from MartinKG <mgansser at alice.de> 2015-07-05 13:15:26 CEST ---
(In reply to comment #4)
> Hi, 
> 
> Observation nº1 
> 
> %setup -q  and  %setup -qn %{name}-%{version} do the same i.e. by default -n is
> %{name}-%{version} 
> 
> so you can use %setup -q
> 
done

> Observation nº2
> About make install DESTDIR=%{buildroot}  you could use  %make_install 
> 
> I learn this today , 
> | there are _two_ macros:
> |
> |  1. %makeinstall
> |  2. %make_install
> 
> | The %makeinstall macro should be avoided, because it redefines many path 
> | variables that can lead to ugly side-effects.
> 
> | The %make_install macro does exactly what you want. Really do take a look at
> | "rpm -E %make_install" to see what the macro does. It's there to make |
> packaging easier. 
> 
done

> Observation nº3  : 
> E: invalid-appdata-file /usr/share/appdata/girl.appdata.xml
> why rpmlint is saying this ? 
> 
checked

appstream-util validate-relax  girl.appdata.xml
girl.appdata.xml: OK

> Observation nº4  : 
> girl-debuginfo.x86_64: E: incorrect-fsf-address in 17 files 
> 
> please see [1] we should inform upstream that should correct the address in the
> license. 
> 
> For example [2]
> 
> [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> 
> [2] https://sourceforge.net/p/smb4k/tickets/40/
> 
already reported upstream.


> Even though, package APPROVED ! 
> 
> PS: on Package CVS request please just ask for: Branches: devel, F-20 is EOL,
> F-21 is devel and F-22 doesn't exist

ok, many thanks for your review.

new rpm packages:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/girl.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/girl-6.0.0-3.fc22.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.