[Bug 3688] Review request: vdr-mpv - A mpv player plugin for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3688

--- Comment #3 from MartinKG <mgansser at alice.de> 2015-07-06 21:33:19 CEST ---
(In reply to comment #2)
> As Martin mention it is a small program... 
> 
> package review 
>  0 errors, 0 warnings. 
> 
> Only question that I have is: why we need added -fPIC in %build ? 
> 
> %build
> make CFLAGS="%{optflags} -fPIC" CXXFLAGS="%{optflags} -fPIC" %{?_smp_mflags}
> all
> 
> Package APPROVED

compilation fails without -fPIC

g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches  -m64 -mtune=generic -Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -shared mpv.o config.o control.o
filebrowser.o osd.o player.o playmenu.o setup.o status.o -lXrandr  -lmpv  -o
libvdr-mpv.so
/usr/bin/ld: mpv.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be
used when making a shared object; recompile with -fPIC

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.