[Bug 3554] Review request: aqualung - Music Player for GNU/Linux

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554

--- Comment #3 from Mamoru TASAKA <mtasaka at fedoraproject.org> 2015-03-01 15:28:00 CET ---
Program itself seems to be working correctly.

* License
  - Well, please never modify license text downstream, even
    if rpmlint complains for it.
    License modification must be done only on upstream.

* BuildRequires:
  - For pkgconfig based BR (i.e. "PKG_CHECK_MODULES" in configure.ac)
    it is better to use pkgconfig vitual BR, like
    BuildRequires: pkgconfig(flac) (not a blocker)

* License tag
  - (not a blocker) License tag can simply be GPLv2+
    (This is effectively one single binary, and writing multiple
     licenses where GPLv2+ is predominant actually does not make
     sense)

* License file
  - Use %license for license text:
   
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

* %defattr
  - %defattr can be removed (current rpmbuild does not need this
    any longer)

* rpmfusion category
  - Well, I think this is "free" category for rpmfusion, not "nonfree"
> This package needs to link the following nonfree 
> libraries, so this package is nonfree.
    My recognition is that they are actually "free" (patent issue
    or so does not make it "nonfree" category), would you check
    this? (Also check MOCK.log attached)

* incorrect-fsf-address rpmlint
  - Please ping upsteam later (check rpmlint result for -debuginfo rpm)
    (not a blocker)

Well, please check above. I don't see strict blocker for this package.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.