[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827

Hans de Goede <j.w.r.degoede at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |j.w.r.degoede at gmail.com
             Blocks|2                           |5
         AssignedTo|rpmfusion-package-review at rp |j.w.r.degoede at gmail.com
                   |mfusion.org                 |

--- Comment #1 from Hans de Goede <j.w.r.degoede at gmail.com> 2015-11-06 13:15:39 CET ---
Hi,

Thanks for doing this, it is great to see some movement wrt this.

Full review done :

Good:
---------
- rpmlint checks return:
 rfpkg-rpmfusion-free.noarch: W: no-documentation
 rfpkg-rpmfusion-nonfree.noarch: W: no-documentation
 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
 -> All ok
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

I do not think that we need to support EPEL-5, as you say there is no pyrpkg
there, and I do not really expect anyone to be maintaining rpmfusion packages
on EPEL-5, they may maintain packages for EPEL-5 (although even that hardly
happens), but I do not expect them to be doing that on an actual EL5 system.

If we drop support for EPEL-5, the spec file can be cleaned up a lot. Then the
following can all be removed:

BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

%if 0%{?rhel} == 5
Requires:       python-kitchen
%endif

rm -rf $RPM_BUILD_ROOT      (from %install)

%clean
rm -rf $RPM_BUILD_ROOT


Also the installing of the bash-completion support under /etc in rawhide seems
like a bug to me which should be fixed, and then:

%if 0%{?fedora} < 24 && 0%{?rhel} < 5
%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/rfpkg
%else
%dir %{_sysconfdir}/bash_completion.d
%config(noreplace) %{_sysconfdir}/bash_completion.d/rfpkg
%endif

Can be turned into just:

%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/rfpkg

None of this really is a blocker, so I'm going to approve this, but it would be
nice to get this fixed, either before importing the package, or immediately
after import.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.