[Bug 3827] Review request: rfpkg - RPMFusion utility for working with dist-git

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3827

--- Comment #9 from Hans de Goede <j.w.r.degoede at gmail.com> 2015-11-11 10:54:58 CET ---
Hi,

(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > New release:
> > > 
> > > SPEC: https://sagitter.fedorapeople.org/rfpkg/rfpkg.spec
> > > SRPM:https://sagitter.fedorapeople.org/rfpkg/rfpkg-1.20-3.20151027git62a8b0.fc23.src.rpm
> > 
> > About this bit:
> > 
> > ##Fix installation of the script file for Bash
> > %if 0%{?fedora} > 23 || 0%{?rhel} > 5
> > ...
> > %endif
> > 
> > When I said that that should be fixed, I meant it should be fixed in the
> > upstream git repo, there is some code in there which detects where to put the
> > bash-completion, and it seems to be misbehaving on rawhide (not sure what is
> > the right thing to do on EL5, but that does not matter).
> 
> rfpkg is a fork of fedpkg-1.20; its setup.py pushes rfpkg bash-completion file
> into directory indicates by command:
> 
>  pkg-config --variable=completionsdir bash-completion
> 
> else
> 
> in /etc/bash_completion.d.
> 
> With the latest fedpkg-1.21, setup.py is modified to pushing fedpkg.bash in
> /etc/bash_completion.d.

That is weird, since system default config belongs under /usr/share and /etc is
for local user modifications.

Also there is no git history for 1.21 upstream:

https://git.fedorahosted.org/cgit/fedpkg.git

I believe it is best to ask Pavol Babincak <pbabinca at redhat.com> about this,
both the missing of 1.21 in upstream git, and why they are using
/etc/bash_completion.d where all Fedora packages are moving towards
/usr/share/bash-completion/completions.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.