[Bug 3863] New: Review request: game-data-packager - Installer for game data files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3863

             Bug #: 3863
           Summary: Review request: game-data-packager - Installer for
                    game data files
    Classification: Unclassified
           Product: Package Reviews
           Version: Current
          Platform: All
        OS/Version: GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Review Request
        AssignedTo: rpmfusion-package-review at rpmfusion.org
        ReportedBy: alexandre.detiste at gmail.com
                CC: rpmfusion-package-review at rpmfusion.org


Various games are divided into two logical parts: engine and data.
.
game-data-packager is a tool which builds .rpm files for game
data which cannot be distributed (such as commercial game data).

Almost all ScummVM, Doom, Quake games are supported + others.
http://pkg-games.alioth.debian.org/game-data/

-------------

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/tools/game-data-packager.spec

The RPM support has been added _after_ the last release,
so I temporary use dummy snapshot tarballs until next release.

These are built this way:

git archive --prefix=game-data-packager/ --format tar.gz master >
../rpmbuild/SOURCES/game-data-packager.tar.gz

Which makes rmplint complain:
"game-data-packager.src: W: invalid-url Source0: game-data-packager.tar.gz"

-------------

This tool originated in Debian "contrib", because it's
free software, but of no use without non-free assets;
likewise it doesn't belong in Fedora.

https://bugzilla.redhat.com/show_bug.cgi?id=1279177 :

"game-data-packager's sole purpose is to repackage non-free game resources into
distro packages. As such it has no place in Fedora itself."

---------------------------
remaining rpmlint:

game-data-packager.noarch: E: zero-length
/etc/game-data-packager/quake3-mirrors

  well, maybe GDP should use data from filewatcher to enhance it's mirror
lists.
  either at build-time (bad, need internet acces), from time to time,
  or at run time. We have SHA1 hashes for files, so the source doesn't
  much matter.
  http://www.filewatcher.com/m/linuxq3apoint-1.32b-3.x86.run.30923961-0.html

game-data-packager.noarch: E: script-without-shebang 
/usr/share/bash-completion/completions/game-data-packager

  that's not a script intended to be run,
  but a script fragement to be sourced

game-data-packager.noarch: E: script-without-shebang
/usr/share/games/game-data-packager/game_data_packager/games/__init__.py
game-data-packager.noarch: E: script-without-shebang
/usr/share/games/game-data-packager/game_data_packager/version.py
game-data-packager.noarch: E: script-without-shebang
/usr/share/games/game-data-packager/game_data_packager/paths.py

 these are generated during the build, a shebang could be added too


-----

This is my first RPM Fusion package.


-------

upstream Makefile lacks a "make install" rule;
having this would allow to trim the specfile.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.