[Bug 4182] Review request: ffmulticonverter - GUI File Format Converter

RPM Fusion Bugzilla noreply at rpmfusion.org
Fri Aug 12 22:53:37 CEST 2016 

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4182

--- Comment #8 from leigh scott <leigh123linux at gmail.com> 2016-08-12 22:53:37 CEST ---
Review failed

==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
1) Package License is wrong, it needs changing to 

License:    GPLv3+

GPL (v3 or later)
-----------------
ffmulticonverter-1.8.0/ffmulticonverter/about_dlg.py
ffmulticonverter-1.8.0/ffmulticonverter/audiovideotab.py
ffmulticonverter-1.8.0/ffmulticonverter/documenttab.py
ffmulticonverter-1.8.0/ffmulticonverter/ffmulticonverter.py
ffmulticonverter-1.8.0/ffmulticonverter/imagetab.py
ffmulticonverter-1.8.0/ffmulticonverter/preferences_dlg.py
ffmulticonverter-1.8.0/ffmulticonverter/presets_dlgs.py
ffmulticonverter-1.8.0/ffmulticonverter/progress.py
ffmulticonverter-1.8.0/ffmulticonverter/utils.py


2) Requires:   python-qt5 is wrong, this is a python3 package so change it to

Requires:   python3-qt5


3) Unowned directory /usr/share/ffmulticonverter

change

%{_datadir}/%{name}/presets.xml

to

%{_datadir}/%{name}/



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 19 files have
     unknown license. Detailed output of licensecheck in
     /home/leigh/Desktop/ffmulticonverter/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/ffmulticonverter
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/ffmulticonverter
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: ffmulticonverter-1.8.0-2.fc24.noarch.rpm
          ffmulticonverter-1.8.0-2.fc24.src.rpm
ffmulticonverter.src: W: spelling-error %description -l en_US ffmpeg -> MPEG
ffmulticonverter.src: W: spelling-error %description -l en_US unoconv ->
unconvinced
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
ffmulticonverter (rpmlib, GLIBC filtered):
    /usr/bin/python3
    ImageMagick
    ffmpeg
    python(abi)
    python-qt5
    unoconv



Provides
--------
ffmulticonverter:
    application()
    application(ffmulticonverter.desktop)
    ffmulticonverter



Source checksums
----------------
http://sourceforge.net/projects/ffmulticonv/files/ffmulticonverter-1.8.0.tar.gz
:
  CHECKSUM(SHA256) this package     :
5f2d8ed0acc70952c54fb1f3d13caa858988ebc7cc3b99b9fae7b6856d6a7f85
  CHECKSUM(SHA256) upstream package :
5f2d8ed0acc70952c54fb1f3d13caa858988ebc7cc3b99b9fae7b6856d6a7f85

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the rpmfusion-developers mailing list