[Bug 2682] Review request: higan - A Nintendo multi-system emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2682

Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musuruan at gmail.com

--- Comment #15 from Andrea Musuruane <musuruan at gmail.com> 2016-08-15 19:10:43 CEST ---
(In reply to comment #14)
> SRPM URL: http://lesloueizeh.com/belegdol/higan-0.100-1.fc21.src.rpm
> Spec URL: http://lesloueizeh.com/belegdol/higan.spec
> 
> I updated the spec to v100 in case someone would like to carry the torch.

I had a glance at higan. This is what I found.

A new upstream version has been release: v101.

I'm a bit confused about higan version numbers. Upstream uses v100. You use
v0.100. Debian and Mageia follow the same convention as upstream.

I would amend the Summary removing Nintendo. higan also support WonderSwan and 
WonderSwan Color which were made by Bandai.

Upstream URL is wrong. Correct one is:
http://byuu.org/emulation/higan/

Upstream Source is also wrong. The correct one is:
http://download.byuu.org/higan_v100-source.7z

README.higan still talks about bsnes and ~/.config/bsnes.

I think the following is not correct:
Obsoletes:      bsnes < 0.091-3
Provides:       bsnes = %{version}-%{release}

In this way you cannot obsolete bsnes-0.091-3 which has been released:
http://koji.rpmfusion.org/koji/packageinfo?packageID=20

You may want to improve the description. Here you can find the one used by
Debian as a reference:
https://anonscm.debian.org/cgit/pkg-games/higan.git/tree/debian/control

%build section can be shortened - if maintainer wishes - in the following way:
%make_build -C higan
%make_build -C icarus

The source package does not include the text of the license. The packager
should contact upstream and encourage them to correct this mistake.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.