[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009

rc040203 at freenet.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #15 from rc040203 at freenet.de 2016-08-23 09:07:33 CEST ---
(In reply to comment #14)
> > 3. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*
> done

Did you? I still see 
...
gzip -f %{buildroot}%{_datadir}/man/man1/QMPlay2.1
...
%{_mandir}/man1/%{pname}.1.gz
in your spec.

Remove the call to gzip and add {_mandir}/man1/%{pname}.1 to %files.


Furthermore:
- AUTHORS, ChangeLog etc. are supposed to be installed into %{_pkgdocdir} and
not into %{_datadir}/%{name}

Either change the line, which is installing them to install into %{_pkgdocdir}
or remove this line and use
%doc AUTHORS ChangeLog ...

- Similar with %license.
Here 
%license LICENSE
would be sufficient.

- qmplay2-kde-integration installs a file to /usr/share/solid/actions, however
this directory is unowned (Also cf. comment#6 above).

- The way you are copying the libs into their final destination is "arguable".
I would write it this way:

-%if "%{_lib}" == "lib64"
-mv %{buildroot}/%{_prefix}/{lib,lib64}
+%if "%{_lib}" != "lib"
+mv %{buildroot}%{_prefix}/lib %{buildroot}%{_libdir}
 %endif

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.